esy build fails on building skia

[Benney Au]

When building on windows 10 I get this error msg

info esy build 0.6.6 (using package.json)
info building esy-skia@github:revery-ui/esy-skia#d60e5fe@d41d8cd9
error: build failed with exit code: 1
  build log:
    # esy-build-package: building: esy-skia@github:revery-ui/esy-skia#d60e5fe
    # esy-build-package: pwd: C:\Users\benne\.esy\3\b\esy_skia-7ed409d0
    # esy-build-package: running: "bash" "./esy/build.sh" "windows" "C:/Users/benne/.esy/3_________________________________________________________________/i/esy_libjpeg_turbo-639d22ad"
    buildtools                           @ 505de88083136eefd056e5ee4ca0f01fe9b33de8
    common                               @ 9737551d7a52c3db3262db5856e6bcd62c462b92
    third_party/externals/angle2         @ b001528ffa00e7c15a5002124f707570e59a5697
    third_party/externals/dng_sdk        @ 96443b262250c390b0caefbf3eed8463ba35ecae
    third_party/externals/expat          @ android-6.0.1_r55
    third_party/externals/freetype       @ fa6da7bf6dcbcfa22d2464259ad1cccee3233189
    third_party/externals/googletest     @ dd43b9998e9a44a579a7aba6c1309407d1a5ed95
    third_party/externals/harfbuzz       @ 1.4.2
    third_party/externals/icu            @ ec9c1133693148470ffe2e5e53576998e3650c1d
    third_party/externals/imgui          @ 6384eee34f08cb7eab8d835043e1738e4adcdf75
    third_party/externals/jsoncpp        @ 1.0.0
    third_party/externals/libjpeg-turbo  @ 1.5.3
    third_party/externals/libpng         @ v1.6.33
    third_party/externals/libwebp        @ v0.6.1
    third_party/externals/lua            @ v5-3-4
    third_party/externals/microhttpd     @ 748945ec6f1c67b7efc934ab0808e1d32f2fb98d
    third_party/externals/piex           @ bb217acdca1cc0c16b704669dd6f91a1b509c406
    third_party/externals/rapidjson      @ af223d44f4e8d3772cb1ac0ce8bc2a132b51717f
    third_party/externals/sdl            @ 5d7cfcca344034aff9327f77fc181ae3754e7a90
    third_party/externals/sfntly         @ b18b09b6114b9b7fe6fc2f96d8b15e8a72f66916
    third_party/externals/spirv-headers  @ 661ad91124e6af2272afd00f804d8aa276e17107
    third_party/externals/spirv-tools    @ e9e4393b1c5aad7553c05782acefbe32b42644bd
    third_party/externals/swiftshader    @ cbb80f5f0078a9941f3ec43e83e52c3d15a43bea
    third_party/externals/zlib           @ e7afdfe128e01ca480a28f757b571957befdd962
    ERROR at //gn/BUILDCONFIG.gn:185:3: Assertion failed.
      assert(win_vc != "")  # Could not find VC installation. Set win_vc to your VC directory.
      ^-----
    error: command failed: "bash" "./esy/build.sh" "windows" "C:/Users/benne/.esy/3_________________________________________________________________/i/esy_libjpeg_turbo-639d22ad" (exited with 255)
    esy-build-package: exiting with errors above...

  building esy-skia@github:revery-ui/esy-skia#d60e5fe
esy: exiting due to errors above

I tried to set the variable like this but it didn't work:

set win_vc=C:\Program Files (x86)\Microsoft Visual Studio\2019\Professional\VC

[Glenn Slotte]

I don't use Windows, but I understand it needs Visual Studio 2017 VC Tools. Visual Studio 2019 won't work. See https://github.com/revery-ui/revery/wiki/Building-&-Installing#for-windows-native

[parkerault]

I tried three times to make this work, but I was only able to succeed by manually installing the VC Tools 2017 package with the Microsoft installer. It can be downloaded here, but Unfortunately this requires a microsoft account.

[Glenn Slotte]

Thanks @parkerault! I'll assume this is resolved then and close this out. Let me know if its's not and I'll reopen.

[parkerault]

@glennsl It's resolved in the sense that I was able to fix it for myself, but not in the sense that the automated build script fails. :)

[Glenn Slotte]

@parkerault Which automated build script? This is a prerequisite. It might be a good idea to add this to the documentation though.

[parkerault]

Ah, sorry. This was so long ago I've forgotten where the problem happened. It might have been that npm install -g windows-build-tools wasn't properly installing VC Tools, but that's not something that you can fix.