reverbdotcom / reverb-magento

Magento 1.x plugin for syncing with Reverb

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

magento mass attribute update does not trigger Reverb updates

skwp opened this issue · comments

if using magento's mass attribute update, we do not trigger reverb updates. Customers are forced to hit bulk sync.

So the goal here is to have mass attribute trigger a bulk sync? Or should we queue up background listing sync tasks only for the products which were updated?

And it should trigger regardless of whether the updated attributes are relevant to Reverb or not? For instance if only 1 attribute was updated and it's not an attribute being sent to Reverb?

I have pushed a commit for this but haven't been able to fully test it yet

@dunagan5887 Yes, because currently if you do mass attribute update, reverb sync isn't queued at all.
What magento event are you using as a trigger? product_attribute_save_after ?

Ideally it only syncs the products that have changed meaningful to reverb but it would be fine to sync all

Sent from my iPhone

On Feb 18, 2016, at 7:42 PM, zztimur notifications@github.com wrote:

@dunagan5887 Yes, because currently if you do mass attribute update, reverb sync isn't queued at all.
What magento event are you using as a trigger? product_attribute_save_after ?


Reply to this email directly or view it on GitHub.

Ideally there should be a pre-sync logic that would check

Currently triggering this on catalog_product_attribute_update_before. This event does pass the attributes data to the observers, so I could put in a pre-sync logic check to inspect which attributes are being updated. I imagine that if the client has mapped Magento attributes to the Reverb Make/Model/Price fields, those attributes should be considered as relevant correct?