Update deprecated dependencies
lsabi opened this issue · comments
Is your feature request related to a problem? Please describe.
Kinda of a bug, kinda feature request.
When build a docker container with docker build -t rethink:dev ., the following pops out of the terminal.
Log
npm WARN old lockfile
npm WARN old lockfile The package-lock.json file was created with an old version of npm,
npm WARN old lockfile so supplemental metadata must be fetched from the registry.
npm WARN old lockfile
npm WARN old lockfile This is a one-time fix-up, please be patient...
npm WARN old lockfile
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@angular-devkit/core@11.2.6',
npm WARN EBADENGINE required: { node: '>= 10.13.0', npm: '^6.11.0 || ^7.5.6', yarn: '>= 1.13.0' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@angular-devkit/schematics@11.2.6',
npm WARN EBADENGINE required: { node: '>= 10.13.0', npm: '^6.11.0 || ^7.5.6', yarn: '>= 1.13.0' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@angular-devkit/schematics-cli@0.1102.6',
npm WARN EBADENGINE required: { node: '>= 10.13.0', npm: '^6.11.0 || ^7.5.6', yarn: '>= 1.13.0' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@angular-devkit/core@11.2.4',
npm WARN EBADENGINE required: { node: '>= 10.13.0', npm: '^6.11.0 || ^7.5.6', yarn: '>= 1.13.0' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@angular-devkit/schematics@11.2.4',
npm WARN EBADENGINE required: { node: '>= 10.13.0', npm: '^6.11.0 || ^7.5.6', yarn: '>= 1.13.0' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: '@schematics/schematics@0.1102.6',
npm WARN EBADENGINE required: { node: '>= 10.13.0', npm: '^6.11.0 || ^7.5.6', yarn: '>= 1.13.0' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'rethinkdb-ts@3.0.0-next.1',
npm WARN EBADENGINE required: { node: '>=12.x <=16.x' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
npm WARN deprecated querystring@0.2.0: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
npm WARN deprecated flatten@1.0.3: flatten is deprecated in favor of utility frameworks such as lodash.
npm WARN deprecated formidable@1.2.2: Please upgrade to latest, formidable@v2 or formidable@v3! Check these notes: https://bit.ly/2ZEqIau
Describe the solution you'd like
Upgrading deprecated dependencies.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Fixed the build. Took a while to make it=)
On branch rethink/code-clean I still get the following
Sending build context to Docker daemon 2.225MB
Step 1/12 : FROM node:gallium-alpine as build
---> 59b389513e8a
Step 2/12 : WORKDIR /app
---> Using cache
---> 137b9d332858
Step 3/12 : COPY package.json package-lock.json ./
---> Using cache
---> 7de29d33acb2
Step 4/12 : RUN npm i
---> Running in 8443aa9d175d
npm WARN deprecated superagent@7.1.2: Deprecated due to bug in CI build https://github.com/visionmedia/superagent/pull/1677\#issuecomment-1081361876
npm WARN deprecated querystring@0.2.1: The querystring API is considered Legacy. new code should use the URLSearchParams API instead.
added 1371 packages, and audited 1372 packages in 57s
160 packages are looking for funding
run `npm fund` for details
1 high severity vulnerability
To address all issues, run:
npm audit fix
Run `npm audit` for details.
npm notice
npm notice New minor version of npm available! 8.5.0 -> 8.7.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.7.0>
npm notice Run `npm install -g npm@8.7.0` to update!
npm notice
Removing intermediate container 8443aa9d175d
---> a6e77a3aa552
Step 5/12 : COPY . .
---> 420d29068c58
Step 6/12 : RUN npm run build
---> Running in 697f5440c5e5
> admin@0.0.1 prebuild
> rimraf build
> admin@0.0.1 build
> cross-env NODE_ENV=production webpack
asset server.js 3.92 KiB [emitted] [minimized] (name: server)
orphan modules 8.21 KiB [orphan] 19 modules
./src/main.ts + 19 modules 8.69 KiB [not cacheable] [built] [code generated]
webpack 5.72.0 compiled successfully in 3896 ms
asset app.585919a8edc80a64e256.js 4.32 MiB [emitted] [immutable] [minimized] [big] (name: main) 1 related asset
asset favicon.ico 5.55 KiB [emitted] [from: static/favicon.ico] [copied]
asset index.html 584 bytes [emitted]
orphan modules 1.86 MiB [orphan] 822 modules
runtime modules 2.03 KiB 5 modules
cacheable modules 1.64 MiB
modules by path ../../node_modules/ 1.27 MiB 159 modules
modules by path ./src/ 381 KiB
modules by path ./src/*.tsx 291 KiB
./src/index.tsx + 72 modules 284 KiB [built] [code generated]
./src/data-explorer.tsx 6.82 KiB [built] [code generated]
modules by path ./src/*.ts 87.4 KiB
./src/socket.ts + 24 modules 85.8 KiB [built] [code generated]
./src/requests.ts 1.64 KiB [built] [code generated]
./src/top-bar/data-hooks.ts 2.07 KiB [built] [code generated]
WARNING in ../../node_modules/@reatom/debug/build/index.es.js 1:2296-2297
export 'nameToIdDefault' (imported as 't') was not found in '@reatom/core' (possible exports: addToSetsMap, callSafety, createAtom, createReatomError, createStore, createTemplateCache, createTransaction, defaultStore, delFromSetsMap, getState, isAction, isActionCreator, isAtom, isFunction, isObject, isString, noop, pushUnique)
@ ./src/store.ts 2:0-53
@ ./src/app.tsx 15:0-32 96:15-20
@ ./src/index.tsx 3:0-28 5:35-38
WARNING in ../../node_modules/@reatom/debug/build/index.es.js 1:2766-2767
export 'initAction' (imported as 'r') was not found in '@reatom/core' (possible exports: addToSetsMap, callSafety, createAtom, createReatomError, createStore, createTemplateCache, createTransaction, defaultStore, delFromSetsMap, getState, isAction, isActionCreator, isAtom, isFunction, isObject, isString, noop, pushUnique)
@ ./src/store.ts 2:0-53
@ ./src/app.tsx 15:0-32 96:15-20
@ ./src/index.tsx 3:0-28 5:35-38
WARNING in ../../node_modules/@reatom/debug/build/index.es.js 1:2840-2846
export 'initAction' (imported as 'r') was not found in '@reatom/core' (possible exports: addToSetsMap, callSafety, createAtom, createReatomError, createStore, createTemplateCache, createTransaction, defaultStore, delFromSetsMap, getState, isAction, isActionCreator, isAtom, isFunction, isObject, isString, noop, pushUnique)
@ ./src/store.ts 2:0-53
@ ./src/app.tsx 15:0-32 96:15-20
@ ./src/index.tsx 3:0-28 5:35-38
WARNING in asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
This can impact web performance.
Assets:
app.585919a8edc80a64e256.js (4.32 MiB)
WARNING in entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
Entrypoints:
main (4.32 MiB)
app.585919a8edc80a64e256.js
WARNING in webpack performance recommendations:
You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
For more info visit https://webpack.js.org/guides/code-splitting/
webpack 5.72.0 compiled with 6 warnings in 21860 ms
Removing intermediate container 697f5440c5e5
---> 5690460cda24
Step 7/12 : FROM node:alpine as release
---> 9e17f47b0a78
Step 8/12 : COPY package.json package-lock.json ./
---> aaf5db2baebc
Step 9/12 : RUN npm i --only=prod
---> Running in 47295386937a
npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE package: 'rethinkdb-ts@3.0.0-next.1',
npm WARN EBADENGINE required: { node: '>=12.x <=16.x' },
npm WARN EBADENGINE current: { node: 'v17.1.0', npm: '8.1.2' }
npm WARN EBADENGINE }
added 200 packages, and audited 201 packages in 21s
25 packages are looking for funding
run `npm fund` for details
1 high severity vulnerability
To address all issues, run:
npm audit fix
Run `npm audit` for details.
Removing intermediate container 47295386937a
---> eee6f5247b30
Step 10/12 : COPY --from=build /app/build ./build
---> 3e1f176b430b
Step 11/12 : CMD ["npm", "start"]
---> Running in c993f2df5f12
Removing intermediate container c993f2df5f12
---> 33995c652560
Step 12/12 : EXPOSE 3000
---> Running in 3c5488bf544f
Removing intermediate container 3c5488bf544f
---> f8b7047096a5
Successfully built f8b7047096a5
Successfully tagged rethink:dev
Is it on the main branch?
code cleaning breaks heavily, I wanted to migrate on new mui version, but thats didn't go fine
I think it is better to stick to this version, do the useful stuff and then try to migrate again
But if someone is capable to finish the job- it ld be cool
The project has moved far away since issue opened. Closing