@ModelAttribute support

Question

@ModelAttribute support

bclozel opened this issue 12 years ago · comments

Add test cases and implement @ModelAttribute support:

on method arguments (already there? If so, add test cases anyway)
on controller methods, see Spring documentation
update RouterHandlerAdapter with changes in RequestMappingHandlerAdapter

Brian Clozel · Answer 1 · Sun Apr 08 2012 05:03:27 GMT+0800 (China Standard Time)

So, I'm actually considering dropping the custom routerhandleradapter and rely on spring3.1 default one.
I will push some changes on issue_6 branch.

Brian Clozel · Answer 2 · Tue Apr 10 2012 16:46:01 GMT+0800 (China Standard Time)

Done.
With this branch, springmvc-router covers all new Spring 3.1 features... and BC breaks.
So the codebase won't be Spring 3.0 compatible anymore.

@BradHouse - should I delay this for a future version?

Bradley Dwyer · Answer 3 · Tue Apr 10 2012 19:25:26 GMT+0800 (China Standard Time)

I don't think you should delay.

Brian Clozel · Answer 4 · Wed Apr 11 2012 05:17:56 GMT+0800 (China Standard Time)

merged in master

Electro Type · Answer 5 · Sat Apr 14 2012 21:18:31 GMT+0800 (China Standard Time)

Thanks for that fix! I'm still testing, but it seems springmvc-router now has everything my application needs.

Brian Clozel · Answer 6 · Sun Apr 15 2012 00:34:58 GMT+0800 (China Standard Time)

Great. Release 0.7 is on its way, I'd like to ship it with as much as BC-breaks as possible.

Electro Type · Answer 7 · Sun Apr 15 2012 22:43:52 GMT+0800 (China Standard Time)

Perfect, thanks.

Everything runs very well. I was affraid some things like "@PathVariable" (in front of an action method's parameter) wouldn't work as expected but they actually seem to do!

One thing I still don't understand is why the names of the controllers have to have their first letter lowercased (in the routes file and when reverse-routing them)? My controller name is not "testController", it's "TestController". I don't see why it is required to lowercase the first letter to make your routing system work?

The only other thing I see missing is a taglib for jsp (I don't use Freemarker or Velocity)... But that shouldn't be hard to implement by myself.

Thanks again for this project!

(Sorry if this is not the right place to discuss all this, since it's not really related to the @ModelAttribute issue... Is there a better place?)

Brian Clozel · Answer 8 · Mon Apr 16 2012 05:56:22 GMT+0800 (China Standard Time)

Good.

I'll open an issue regarding a JSP taglib (or you can contribute your own if you want to).
Opening issues is a good way to start; I thought about creating a discussion group for questions/announcements. Would that work out for you?

Electro Type · Answer 9 · Mon Apr 16 2012 06:20:48 GMT+0800 (China Standard Time)

I don't feel confortable enough to contribute (I'm very new to github, and I still use svn for my projects), but the taglib is really easy to code anyway (it took me 15 minutes).

A forum is a good idea!

Springmvc-router is now fully integrated to my new application structure. Thanks again for that, I really prefere this kind of routing to the annotations based one.