Overlay sometimes freezes; stays off/white background on refresh

Question

resir014 opened this issue 4 years ago · comments

Some users are reporting the viz could get stuck in a certain position after a while. Refreshing shows a white background, but the viz remains off.

Removing the web source on OBS and re-adding it seems to fix the problem.

Resi Respati · Answer 1 · Tue Nov 10 2020 19:46:16 GMT+0800 (China Standard Time)

This has been tracked down to a memory leak issue, caused by the way we poll the gamepad data.

Benchmark Results

Standalone gamepad (TMViz)

Dropped the framerate passed onto useInterval() and use the standard 1000ms interval instead. This means the framerate option is now deprecated.
Made use of requestAnimationFrame() to update gamepad input visualisation.
Rewritten useGamepad() to be settings-agnostic, making use of requestAnimationFrame() mentioned above as well as React Context.

A fix has been attempted in #12 with promising results. Will further dogfood our current solution.

Resi Respati · Answer 2 · Wed Nov 11 2020 03:52:48 GMT+0800 (China Standard Time)

Update: It seems that Chakra UI is causing the memory leak. I guess this project is a perfect way to stress-test public design systems...

Rewritten overlay section entirely in CSS Modules. Chakra UI is still retained for the overlay customiser.
Completely remove polling with useInterval. requestAnimationFrame() has already done the trick.

Update: Fix implemented in #13.

Resi Respati · Answer 3 · Thu Nov 12 2020 11:40:02 GMT+0800 (China Standard Time)

The fixes mentioned above is confirmed to be working! Closing now.