highlight now required

Question

highlight now required

wdenton opened this issue 9 years ago · comments

I updated to the new sonic-pi.el package, and then on restart Emacs threw an error because I didn't have the highlight package installed. Installing it by hand fixed things, but somewhere in there, if highlight is now required, Emacs didn't know.

Phil Hagelberg · Answer 1 · Thu Jun 23 2016 18:11:29 GMT+0800 (China Standard Time)

Please consider making this dependency optional; from what I can tell the highlight package is hosted on the EmacsWiki, and it is somewhat irresponsible to encourage users to install software from that source.

Joseph Wilk · Answer 2 · Tue Oct 11 2016 00:09:00 GMT+0800 (China Standard Time)

Until a better solution is contribute or developed I've re-added this.
The PR did not have the same behaviour.

Phil Hagelberg · Answer 3 · Wed Oct 12 2016 06:27:14 GMT+0800 (China Standard Time)

Weird; the effect for me was basically the same. Maybe the faces used by highlight have changed in recent versions of Emacs.