reobin / typewritten

A minimal, lightweight, informative zsh prompt theme

Home Page:https://typewritten.dev

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

bug: Disabling relative path does not work

reobin opened this issue · comments

As mentioned in #104, there seems to be a problem with the TYPEWRITTEN_RELATIVE_PATH option.

Hi @CrystalJewell! can you help me feed this issue with more information?

@reobin Sorry I have been crazy busy this week. I'm circling back to this today. I'll get screenshots and detail what I'm seeing ASAP. The TL:DR is that it appears that TYPEWRITTEN_RELATIVE_PATH="off" is hitting TYPEWRITTEN_RELATIVE_PATH="home" instead.

After getting screenshots of the behavior, it actually looks like pure is ignoring the TYPEWRITTEN_RELATIVE_PATH variable altogether.

TYPEWRITTEN_PROMPT_LAYOUT="pure"
No Relative path export Screen Shot 2021-02-19 at 1 51 14 PM
TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 1 52 23 PM
TYPEWRITTEN_RELATIVE_PATH="git" Screen Shot 2021-02-19 at 1 53 30 PM
TYPEWRITTEN_RELATIVE_PATH="home" Screen Shot 2021-02-19 at 1 54 43 PM
TYPEWRITTEN_RELATIVE_PATH="adaptave" Screen Shot 2021-02-19 at 1 52 23 PM
TYPEWRITTEN_PROMPT_LAYOUT="half-pure"
No Relative path export Screen Shot 2021-02-19 at 1 59 02 PM
TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 00 25 PM
TYPEWRITTEN_PROMPT_LAYOUT="singleline" & TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 02 27 PM
TYPEWRITTEN_PROMPT_LAYOUT="singleline_verbose" & TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 03 44 PM
TYPEWRITTEN_PROMPT_LAYOUT="multiline" & TYPEWRITTEN_RELATIVE_PATH="off" Screen Shot 2021-02-19 at 2 04 38 PM

Thank you for the updates @CrystalJewell !

That was a design decision, actually. Sorry for the confusion! The original Pure prompt displays the whole path that is relative to home. Since the pure layout of typewritten is inspired by the original Pure, I made it ignore TYPEWRITTEN_RELATIVE_PATH variable.

Now that I think about it, there is no reason for it to do that. It would be a nice and easy feature to add to typewritten.

I'll add the feature request in another issue and close this one.

Thank you @CrystalJewell !