The approve bot does not review renovate PRs in Github.com
samueljseay opened this issue · comments
I've hopefully done all the right things:
- Added renovate approve bot with the right permissions to the repository
- I don't have branch restrictions on who can push to the branch
- The branch has automerge enabled and all statuses succeed
If the approve bot was working, would it immediately add a review or could that be delayed? Thats the only thing I'm not sure about because in the process of testing things some branches have been blocked by statuses or conflicts.
here is a public example branch that I ended up merging myself because no review came from renovate: woocommerce/woocommerce-admin#5045
Sorry, I just found that the bot has stopped approving. Taking a look. In the meantime https://github.com/apps/renovate-approve-2 is still working
Actually now I'm not 100% certain about the 2nd bot after I've been experimenting with them
I think they should both now be working. e.g. I just tested with rarkins/automerge1#1
Note: they're only triggered on PR creation or review dismissal events, so won't be periodically checking for any existing PRs that they "missed" adding reviews to them
For what its worth, I've encountered the same issue for both public and private repositories here on GitHub. The second bot seems to be working while the first does not.
If it fails to approve for any PRs created from today onwards then please let me know
@rarkins I have this PR that was opened ~45 minutes ago when only the first bot was installed. It wasn't auto-approved, but a subsequent PR opened after installing the second bot was auto-approved by the second bot.
My Renovate config is located here.
I'm looking into it now. Can you trigger a new PR open?
@rarkins
Here ya go: https://github.com/joshbwlng/renovate-test/pull/35
Looks like both bots approved it this time around, did something change?
I've been fiddling with both bots, including reloading the apps (they run on Glitch), and upgrading/downgrading of probot version. Will leave as-is for now, please alert me again if any problems found.
- Added renovate approve bot with the right permissions to the repository
What are the “right permissions”? Can you please suggest?