Renovate finds package to update but doesn't submit a PR

[Sylvestre Ledru]

Trying on Firefox https://github.com/sylvestre/gecko-dev/
in the log, I can see that renovate clearly finds stuff to update in this file: https://github.com/sylvestre/gecko-dev/blob/master/tools/moztreedocs/requirements.in

For example, I can see in the log:

          {
            "depName": "Sphinx",
            "currentValue": "==3.2.1",
            "datasource": "pypi",
            "fromVersion": "3.2.1",
            "depIndex": 41,
            "warnings": [],
            "fixedVersion": "3.2.1",
            "sourceUrl": "https://github.com/sphinx-doc/sphinx",
            "homepage": "http://sphinx-doc.org/",
            "updates": [
              {
                "fromVersion": "3.2.1",
                "toVersion": "3.3.1",
                "newValue": "==3.3.1",
                "newMajor": 3,
                "newMinor": 3,
                "updateType": "minor",
                "isSingleVersion": true,
                "isRange": true,
                "releaseTimestamp": "2020-11-12T14:22:13"
              }
            ]
          },

I got 19 PR to update version but not more:
https://github.com/sylvestre/gecko-dev/pulls

I do NOT have set prConcurrentLimit.

My config is https://github.com/sylvestre/gecko-dev/blob/master/renovate.json

[Rhys Arkins]

Sorry for the delay in responding. I looked at it on mobile and then unfortunately the notification was marked as read and I forgot about it.

Please see this PR: sylvestre/gecko-dev#41

The config:base preset you use contains a setting of prConcurrentLimit: 20 so you need to override that to get more.

[Sylvestre Ledru]

Oh, many thanks.
What about updating the doc? My expectations was that, if I was using config:base, I would get the default behavior.
https://docs.renovatebot.com/configuration-options/#prconcurrentlimit

Maybe updating to add something in the doc stating something like "config:base comes with a default at 20 PR".
I can write the PR if you agree

[Rhys Arkins]

Renovate the tool's default config is aimed to be as non-opinionated as possible, but the config:base preset that the hosted app proposes in onboarding Pull Requests is moderately opinionated. The problem here is that you're reading the docs about the tool's default settings but your repository contains the config:base preset and follows its behavior. It would be messy and confusing if we tried to annotate the docs with "..unless you include a preset that changes this" clauses on every option.

If you take a look at the onboarding config, it describes what you're seeing:

In other words, repositories get an onboarding config, and that onboarding config is saying accurately what settings you are accepting by merging it. I think the other two approaches are undesirable in comparison:

• Make the default settings opinionated like config:base, or
• Add a warning to dozens of fields in the documentation that.. they can be changed by presets

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed soon if no further activity occurs.
If this question is not done (either you plan to update it or are waiting on someone to respond) then please add a comment here to bump it and/or get the other person's attention.
We aim to do our best to solve every problem. This bot is here to help us clean up issues which are no longer of use to the original poster, and not to close anything prematurely, so bump as you need!