Documentation note about stable branch is not clear enough

Question

jamescrstnwork opened this issue 6 years ago · comments

Toggle documentation has misleading property set, actually it is setOn

Bogdan Chadkin · Answer 1 · Fri Apr 20 2018 15:59:44 GMT+0800 (China Standard Time)

@jamescrstnwork Documentation is right.

James Christian · Answer 2 · Fri Apr 20 2018 16:04:27 GMT+0800 (China Standard Time)

@TrySound no its not, I tried , set method comes as undefined.
I looked into the code and changed it to setOn now it works.

Bogdan Chadkin · Answer 3 · Fri Apr 20 2018 16:05:51 GMT+0800 (China Standard Time)

/cc @renatorib The message is still not clear.

James Christian · Answer 4 · Fri Apr 20 2018 16:13:05 GMT+0800 (China Standard Time)

ohk, I got it.
Its in the stable branch 0.1 : Toggle.js

Renato Ribeiro · Answer 5 · Fri May 04 2018 04:25:36 GMT+0800 (China Standard Time)

I do not see how the message can be clearer. Unfortunately we will still have this problem until 1.0 is released.

If anyone has any suggestions on how to make the message clearer without taking the focus off the rest, feel free to send a PR!

Thanks!