Giters

remotemobprogramming / vscode-mob

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

[Issue] Mob status bar icons are not together when LiveShare is enabled

jrdodds opened this issue · comments

commented

When LiveShare is installed and enabled, the LiveShare icon appears in the midst of the Mob icons in the status bar.

Screen Shot 2023-08-28 at 6 41 37 PM

From left to right the icons are:

  • Mob Start
  • Live Share
  • Mob Next
  • Mob Utils

I'd like to have the Mob * icons together.

Is there a priority or location conflict between Mob Start and Live Share? Is this issue a Mob issue or a LiveShare issue?

(Note there is an open but old VSCode feature request to support user customization the order of the status bar icons - see microsoft/vscode#35744.)

commented

Hi @jrdodds, for me this doesnt happen with liveshare, but probably there is a conflict because happens with you.

I was thinking of having just one button that will show the others (like Mob Utils) to take up less space.
What do you think as user? we gona need 2 clicks to do mob next, but maybe this should be more organized.

commented

The normal flow for an individual user is mob start later followed by either mob next or mob done. Are next and done ever useful or meaningful when the user hasn't done a start? It would be nice if that state could be reflected in the controls.

stateDiagram-v2
  [*] --> Start
  Start --> Next
  Start --> Done
Loading

Live Share has a button and it has a view that shows session details with controls. Clicking the Live Share button starts a session. When a Live Share session has been started, the button changes and clicking it opens the command palette with choices including stopping the session. I don't know if that is a helpful example or not.

commented

Its a good idea, but a little painful to do in some cenarios like:

Step 1: Just showing start button.
Step 2: Start a mob session, now show start, next and done.
Step 3: Change the current branch <- we would need a check to show just the start button (reset the GUI to the initial state), because we are not in a mob session.

Is not a great problem but is something that makes me think. If there is a easy way to check if the user change to a not mob-session this will be great. I will check.