Bump TypeScript version to latest

Question

Bump TypeScript version to latest

asadm opened this issue 5 years ago · comments

Asad Memon commented 5 years ago

Zero is using a bit older version of TypeScript. We need to update it to latest version. Off the top of my head:

Clone, install and run zero locally.
Update in packages here, here.
Run tests (npm run test) and see if all of them pass.
Send PR :)

CmdEngineer · Answer 1 · Wed Oct 30 2019 03:40:05 GMT+0800 (China Standard Time)

I can take this one
EDIT: Though It might conflict with a different issue

Asad Memon · Answer 2 · Wed Oct 30 2019 03:42:29 GMT+0800 (China Standard Time)

Give it a shot if you want, we can always (try to) resolve conflicts 😄

CmdEngineer · Answer 3 · Wed Oct 30 2019 04:49:46 GMT+0800 (China Standard Time)

I received this after testing an unedited version of Zero:
Test Suites: 2 failed, 8 passed, 10 total
Tests: 13 failed, 48 passed, 61 total
Snapshots: 0 total
Time: 1079.525s
Ran all test suites.

After upgrading typescript to 3.6.4 (latest): Test pasted
Typescript seems to work (the new version) however other libraries for me fail the test, which doesn't seem to be because of the change just because of my computer.

Asad Memon · Answer 4 · Wed Oct 30 2019 05:35:13 GMT+0800 (China Standard Time)

Interesting, what OS/version are you on?

I would say still make the PR, our CI will run it against all platforms anyway.

CmdEngineer · Answer 5 · Wed Oct 30 2019 05:51:54 GMT+0800 (China Standard Time)

I am on Windows 10. I will PR it then thank you, please don't mark it as spam then I would highly appreciate it.