Failure in php-7.4.26-openssl3.patch
Whissi opened this issue · comments
Hi,
I just wanted to let you know that I found a small issue in your php-7.4.26-openssl3.patch for PHP 7.4. With GCC 13 I am getting a build error like:
/tmp/build/php-7.4.33/work/sapis-build/cli/ext/openssl/openssl.c: In function ‘php_openssl_pkey_init_legacy_ec’:
/tmp/build/php-7.4.33/work/sapis-build/cli/ext/openssl/openssl.c:4457:31: error: ‘true’ undeclared (first use in this function)
4457 | *is_private = true;
| ^~~~
/tmp/build/php-7.4.33/work/sapis-build/cli/ext/openssl/openssl.c:62:1: note: ‘true’ is defined in header ‘<stdbool.h>’; did you forget to ‘#include <stdbool.h>’?
61 | #include <openssl/cms.h>
+++ |+#include <stdbool.h>
62 | #if PHP_OPENSSL_API_VERSION >= 0x30000
/tmp/build/php-7.4.33/work/sapis-build/cli/ext/openssl/openssl.c:4457:31: note: each undeclared identifier is reported only once for each function it appears in
4457 | *is_private = true;
| ^~~~
make: *** [Makefile:509: ext/openssl/openssl.lo] Error 1
Problem is at line https://git.remirepo.net/cgit/rpms/php/php74.git/tree/php-7.4.26-openssl3.patch#n2274 and the fix should be
-+ *is_private = true;
++ *is_private = 0;
which environment is this ?
I build it fond Fedora 36-38 and RHEL-9 (GCC 11, 12 and 13) without issue
More: true is not 0, but 1
I was building on LFS, and of course, true maps to 1. Thanks!