remarkjs / remark-github

For example, 2.10.2.20200130 (a version number) is rendered as:

2.10.2.[2020013](https://github.com/remarkjs/remark-github/commit/20200130)

when it's expected to be rendered in verbatim. Also, note the omission of the trailing 0.

Try to render 2.10.2.20200130 in an MDX file.

2.10.2.20200130 is rendered incorrectly:

2.10.2.[2020013](https://github.com/remarkjs/remark-github/commit/20200130)

In case of Github:

Hi there! 👋

4843501 is valid sha here, starting with lots of non-hex-digits, and indeed, it doesn’t link:

2.10.2.48435012

GitHub performs a check whether a SHA exists, which we can’t do (it would be too expensive):
4843501
48435013

GitHub also doesn’t publish how this works exactly, so we’ll have to reverse engineer that.

Fix would be to tighten this regex:

Line 10 in 168480a

hash.locator = locator(/\b[a-f\d]{7,40}\b/gi)

...not exactly sure how tight to do it though.

As you might noticed, even if 4843501 is a valid SHA, 2.10.2.4843501 is not treated as a SHA.

Yeah I noticed that (“and indeed, it doesn’t link:”)

Do you have any thoughts on how to tighten that regex?

Fixed, released in 9.0.1!

Thank you so much, @wooorm! Sorry that I didn't have a chance to provide a meaningful feed back on your last question. 🙇

Great, and no problem!

remark-github treats '.YYYYMMDD' as a commit ID.