JOSS Review - Lorenz
bytesnake opened this issue · comments
Lorenz Schmidt commented
Everything looking fine
- runners in place: linting + testing
- tests + examples are working as expected
- pointwise comparison to reference implementation in tests
- crates items are fully documented
- bindings to python interface
Two small things
- you can include your readme for crates with https://blog.guillaume-gomez.fr/articles/2021-08-03+Improvements+for+%23%5Bdoc%5D+attributes+in+Rust
- https://docs.rs/egobox-ego/latest/src/egobox_ego/lib.rs.html#38
Rémi Lafage commented
Thanks for your review. I've taken into account your points in the last commits of the joss branch.