relf / egobox

Efficient global optimization toolbox in Rust: bayesian optimization, mixture of gaussian processes, sampling methods

Home Page:https://joss.theoj.org/papers/10.21105/joss.04737

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

JOSS Review - Lorenz

bytesnake opened this issue · comments

Everything looking fine

  • runners in place: linting + testing
  • tests + examples are working as expected
  • pointwise comparison to reference implementation in tests
  • crates items are fully documented
  • bindings to python interface

Two small things

Thanks for your review. I've taken into account your points in the last commits of the joss branch.