Support Relay 1.3.0

Question

Support Relay 1.3.0

maikelrobier opened this issue 7 years ago · comments

Maikel Ruiz commented 7 years ago

Hi, I tried upgrading to react-relay 1.3.0 and I get this error on runtime:

I guess that's probably caused by the refactoring done in version 1.3.0 to replace promises by observables.

Is this something that has to be updated in relay-subscriptions or is it just something that I got wrong? Thanks.

Ronaldo Lima commented 7 years ago

1

Jimmy Jia · Answer 1 · Thu Jan 18 2018 05:14:43 GMT+0800 (China Standard Time)

The example uses 1.4.1 and it works just fine: https://github.com/edvinerikson/relay-subscriptions/blob/master/examples/todo/package.json#L25

Sibelius Seraphini · Answer 2 · Thu Jan 18 2018 05:23:46 GMT+0800 (China Standard Time)

I think this is a problem on graphql implementation, not with this package

Stefan Foulis · Answer 3 · Thu Feb 01 2018 05:38:35 GMT+0800 (China Standard Time)

@taion Does that mean that relay-subscriptions works with relay "modern". I'm getting confused because the README explicitly mentions "Relay Classic":

Jimmy Jia · Answer 4 · Thu Feb 01 2018 06:09:05 GMT+0800 (China Standard Time)

It works with Relay Classic running on Relay v1.

Stefan Foulis · Answer 5 · Thu Feb 01 2018 07:04:07 GMT+0800 (China Standard Time)

@taion thanks for the clarification 👍