Giters

rehooks / local-storage

React hook which syncs localStorage[key] with the comp.

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

adding a min engine version was a breaking change

zburke opened this issue · comments

commented

e38a412 added a new build requirement and therefore constitutes a breaking change. Anybody using Node.JS < 18 with a ^2.0.0 or ~2.4.0 dependency on this library faces a build failure without making any changes in their code.

The change itself is fine, but it belongs in a new major version, not a patch release. Please consider reverting the change and publishing v2.4.6, then reapplying the change after bumping the version to v3.0.0.