Giters

regro / regolith

Research Group Content Managment System

Home Page:http://regro.github.io/regolith-docs/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

On synched master, one test not passing on test_validate.py

N-G-Asker opened this issue · comments

commented

I believe something broke with the test validator AFTER the June-26 commit 59240bd993d0e4a3e443574a2a997f7fafbc6378.

I am now getting one failed automatic test:

FAILED tests/test_validate.py::test_validate - subprocess.CalledProcessError: Command '['regolith', 'validate']' returned non-zero exit status 1.
commented

I checked out the June 26 commit and ran the tests python run_tests.py with no errors. But the bug seems to also affect commits made June 28th.

commented

I've tried to pinpoint where the bug may have been introduced with this inline comment, but I am not sure the exact cause.

commented
commented

Please see inline comment here for my next hypothesis.

commented
commented

this should be fixed by #949 . @N-G-Asker please can you check and close this issue if it is fixed?

commented

Full test still running (all 400+ checks) but I'm getting more errors than before so far.

I'll dump the summary from my end here momentarily.

======================================================== short test summary info ========================================================
FAILED tests/test_builders.py::test_builder[mongo-cv] - AssertionError: assert '% (c) 2002 M...end{document}' == '% (c) 2002 M...end{d...
FAILED tests/test_builders.py::test_builder[mongo-html] - assert '<!DOCTYPE HT...ody>\n</html>' == '<!DOCTYPE HT...ody>\n</html>'
FAILED tests/test_builders.py::test_builder[mongo-resume] - AssertionError: assert '% (c) 2002 M...end{document}' == '% (c) 2002 M...e...
FAILED tests/test_builders.py::test_builder[fs-cv] - AssertionError: assert '% (c) 2002 M...end{document}' == '% (c) 2002 M...end{docu...
FAILED tests/test_builders.py::test_builder[fs-html] - assert '<!DOCTYPE HT...ody>\n</html>' == '<!DOCTYPE HT...ody>\n</html>'
FAILED tests/test_builders.py::test_builder[fs-resume] - AssertionError: assert '% (c) 2002 M...end{document}' == '% (c) 2002 M...end{...
FAILED tests/test_validate.py::test_validate - subprocess.CalledProcessError: Command '['regolith', 'validate']' returned non-zero exi...
=================================== 7 failed, 488 passed, 2 skipped, 22 warnings in 183.38s (0:03:03) ===================================
commented

you may not be properly sync'd. This is what I get on a sync'ed master:

========== 462 passed, 35 skipped, 18 warnings in 240.01s (0:04:00) ===========

it is skipping some tests that don't run on windows. But I don't think that is the issue as the CI passed before I merged it.

commented

My master is synched and I am still getting the above errors.

Please see here for the dump of my test:
regolith-test-output-synched-master-Jul.3.2022.txt

commented
commented

wait, I think I may have tracked it down....I have unmerged edits locally. Give me a sec.... Sorry about that! I still don't quite understand why the CI passed before, so this may not be it, but fingers crossed.

commented

no, that wasn't it. I removed those unmerged edits and the tests still passed.....

commented

Sounds like a good plan of attack.

As the first step, I have notes out to a couple summers to see if they can replicate the issue I'm having -- thanks for the guidance

commented

Thanks for pushing me in the right direction -- I now think this is a local issue on my end. Thanks to @dpeters001 and @kaylabim for their help!