Enhancement: option to download even if already embedded

Question

Enhancement: option to download even if already embedded

pidiggy opened this issue 4 years ago · comments

The Synology Audio Station requires jpg file in the same folder as album (not embedded in mp3 file).

Appears that if CoverFinder.scan_file finds artwork embedded in the mp3 file, it skips the download even with --test option is set.

Perhaps it could download the album cover art when a new "album_art" option is set true even if there is art-work embedded in the file.

Rego Sen · Answer 1 · Mon Nov 30 2020 14:35:36 GMT+0800 (China Standard Time)

I like this idea, I'll try adding a "force" option, will update you when it's live. Would it be okay if the "force" option replaced existing embedded artwork (as opposed to adding additional embedded art to the mp3 file)?

Rego Sen · Answer 2 · Tue Dec 01 2020 05:03:33 GMT+0800 (China Standard Time)

This should be fixed as well now- if you run with --force at the commandline (or set force to True for CoverFinder()), then it will allow downloading/embedding regardless of existing embedded artwork.

pidiggy · Answer 3 · Tue Dec 01 2020 21:12:45 GMT+0800 (China Standard Time)

Ok thanks I will try it this weekend and give feedback.

Rego Sen · Answer 4 · Fri Jan 01 2021 09:26:22 GMT+0800 (China Standard Time)

Hi, can I close this issue? I got confirmation from another user that force is working, but I wanted to check with you as well.

tylerk86 · Answer 5 · Fri Jan 01 2021 09:33:34 GMT+0800 (China Standard Time)

Most definitely! Thanks again and Happy New Year’s! Tyler Kemp tylerkemp@icloud.com

…

On Dec 31, 2020, 20:26 -0500, Rego Sen ***@***.***>, wrote: Hi, can I close this issue? I got confirmation from another user that force is working, but I wanted to check with you as well. — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or unsubscribe.