Giters

regen-network / regen-web

:seedling: Website and marketplace application

Home Page:https://app.regen.network

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Update profile page url to not be dependent on regen address

ryanchristo opened this issue · comments

commented

Is your feature request related to a problem? Please describe.

A user that has logged in with a web2 login will not have a regen address (at least initially) and therefore the profile page will need to be available using another identifier such as the user id / party id.

We should implement this in a way that makes the user profile urls using the regen address still available and therefore there are two valid urls for a web3 user profile (a url using the regen address and a url using the user id / party id) and one valid url for a web2 user profile (a url using the user id / party id).

  • The user own profile should use /profile/ instead of /ecocredits/.
  • The public profile should use /profiles/{party id or address} instead of /ecocredits/accounts/{party id or address}

We should also make sure redirects are in place for the old public profile path.

Describe the solution you'd like

The public profile page for all users is available using a user id (rather than a regen address). The public profile page for a web3 user can be accessed using the user id or a regen address.

Describe alternatives you've considered (optional)

TBD

Additional context (optional)

TBD

For Admin Use

  • Not duplicate issue
  • Appropriate labels and zenhub epics applied
  • Appropriate contributors tagged
commented

I've updated the issue description with some proposal for the new paths. Let's make sure we all agree on those.

commented

I've updated the issue description with some proposal for the new paths. Let's make sure we all agree on those.

Thank you. Updates look good to me.

Aside from this issue, thinking about the use of /profile got me thinking about the long-term possibility of using slugs and in that case we may want to drop /profiles so the url would be more akin to github and social platforms. Using /profiles at this stage makes the most sense to me though, just thinking out loud a bit.