regebro / tzlocal

A Python module that tries to figure out what your local timezone is

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

3.0b1 breaks unleash-client-python

apahim opened this issue · comments

unleash-client-python depends on apscheduler==3.6.3:
https://github.com/Unleash/unleash-client-python/blob/master/setup.py#L24

apscheduler depends on tzlocal >= 1.2:
https://github.com/agronholm/apscheduler/blob/master/setup.cfg#L27

Installing unleash-client-python gets us tzlocal 3.0b1, which breaks the compatibility:

  File "/usr/local/lib/python3.6/site-packages/reconcile-0.2.2-py3.6.egg/utils/unleash.py", line 38, in get_feature_toggle_state client.initialize_client()
  File "/usr/local/lib/python3.6/site-packages/UnleashClient-3.4.2-py3.6.egg/UnleashClient/__init__.py", line 141, in initialize_client kwargs=fl_args)
  File "/usr/local/lib/python3.6/site-packages/APScheduler-3.6.3-py3.6.egg/apscheduler/schedulers/base.py", line 443, in add_job self._real_add_job(job, jobstore, replace_existing)
  File "/usr/local/lib/python3.6/site-packages/APScheduler-3.6.3-py3.6.egg/apscheduler/schedulers/base.py", line 859, in _real_add_job replacements['next_run_time'] = job.trigger.get_next_fire_time(None, now)
  File "/usr/local/lib/python3.6/site-packages/APScheduler-3.6.3-py3.6.egg/apscheduler/triggers/interval.py", line 66, in get_next_fire_time
return self.timezone.normalize(next_fire_time)
AttributeError: 'backports.zoneinfo.ZoneInfo' object has no attribute 'normalize'

I know I know, apscheduler should fix at least the major version of the requirement:
agronholm/apscheduler#461

Anyway, you might want to know about the compatibility breakage.

Cheers!

Looks like the compatility break is both known & intentional. Closing this.