regclient / regclient

Current Behavior

Calling regctl registry login with invalid credentials returns a zero exit code. When used in GitHub Actions, the step passes despite the login failure.

$ regctl registry login ghcr.io --user "<username>" --pass "<invalid-password>"
time="2024-05-25T06:01:28Z" level=warning msg="Changing login user for registry" host=docker.io new=<username> orig=githubactions
time="2024-05-25T06:01:28Z" level=warning msg="Changing login password for registry" host=docker.io
time="2024-05-25T06:01:28Z" level=warning msg="Failed to ping registry with credentials" err="failed to ping registry ghcr.io: unauthorized"

Expected Behavior

Return a non-zero exit code so other commands are halted.

Example Solution

Version

0.6.1

Environment

Running as binary or container:
Host platform:
Registry description:

Anything else

regclient/cmd/regctl/registry.go

Lines 312 to 316 in 105aee1

    
           if err != nil { 
        
           	log.WithFields(logrus.Fields{ 
        
           		"err": err, 
        
           	}).Warn("Failed to ping registry with credentials") 
        
           }

Thanks for the suggestion. This is fixed in #751. I can see how some would consider that a breaking change, but since there's a flag, it's easy enough for them to go back to skipping the ping, and this feels like the right behavior. Hopefully this doesn't trigger a back and forth of different users with different use cases looking for different behaviors.

Thanks!

…

On Sun, May 26, 2024 at 8:14 AM Brandon Mitchell ***@***.***> wrote: Thanks for the suggestion. This is fixed in #751 <#751>. I can see how some would consider that a breaking change, but since there's a flag, it's easy enough for them to go back to skipping the ping, and this feels like the right behavior. Hopefully this doesn't trigger a back and forth of different users with different use cases looking for different behaviors. — Reply to this email directly, view it on GitHub <#750 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAG6JLSJFIMMQDVA6OEKFVLZEH36JAVCNFSM6AAAAABIIUBU56VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMZSGI2TKNBWGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

	if err != nil {
	log.WithFields(logrus.Fields{
	"err": err,
	}).Warn("Failed to ping registry with credentials")
	}