reg-viz / reg-suit

:recycle: Visual Regression Testing tool

Home Page:https://reg-viz.github.io/reg-suit

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Github: repost comment instead of updating existing comment

janpaul123 opened this issue Β· comments

Is your feature request related to a problem? Please describe.

For the Github comment, it can be unclear that it has been updated. On our team we like to just add a πŸ‘πŸ» emoji on the Github comment as a PR owner, to acknowledge that you've looked at the changes. But then if the comment gets updated, the πŸ‘πŸ» remains, even if you haven't looked at the new changes.

Describe the solution you'd like

It would be nice to have an option to delete the comment and post a new comment. Or even just posting a new comment would suffice (without deleting the old one). For reference, Codecov does something similar, where you can select between 3 different ways of posting/updating a comment: https://docs.codecov.io/docs/pull-request-comments#behavior

Describe alternatives you've considered

Additional context

Screen Shot 2021-02-02 at 5 03 39 PM

Thanks again for an amazing set of tools!!!

For reference, Codecov does something similar,

It seems nice.

@janpaul123 I've added new option, prCommentBehavior .

You can switch to "Delete and Post" via:

/* regconfig.json */
{
  "core": {
    "workingDir": ".reg",
    "actualDir": "screenshot",
    "threshold": 0
  },
  "plugins": {
    "reg-notify-github-plugin": {
      "clientId": "xxxxxxx=",
      "prCommentBehavior": "new"
    },
  }
}

Wow, thanks for the super fast implementation! πŸš€ It works perfectly. πŸ’―