reg-viz / reg-suit

:recycle: Visual Regression Testing tool

Home Page:https://reg-viz.github.io/reg-suit

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Approve/reject snapshot changes

IlyaPuchkaTW opened this issue · comments

Is your feature request related to a problem? Please describe.

Some similar tools like Chromatic, Percy or Happo support approving/declining particular snapshot changes and integrate with GitHub status checks.

Describe the solution you'd like

Generated report should have button to approve/decline all or some snapshots that should post GitHub status check update. This web hook url can be something that developer should pass to the tool manually as a parameter and these buttons could simply call these urls to publish update. When all snapshots are approved status is updated with success.
It would be nice also to be able to filter by approved/declined PRs but that would require some sort of persistence for the state of snapshot.

Describe alternatives you've considered

Right now users would have to request changes on PRs and give a feedback manually.

commented

This would be great. Right now, approval happens by approving the pull request. Github however doesn't allow one to approve their own pull requests, so this feature can not really be used by a single developer.