Filter is not working if ximgdiff is disabled
stevschmid opened this issue · comments
Describe the bug
If ximgdiff is disabled in regconfig.json, filtering in the generated HTML report is not working.
Reproduced step
Check out reg-cli-report-ui, disable ximgdiffConfig in develop/index.html
ximgdiffConfig: { enabled: false, workerUrl: './worker.js' },Start the dev env via yarn start. Filtering is not working.
Cause
this._worker is only created if ximg diff is enabled. Since this._worker is used to relay the filtering messages, the filtering is not working if XIMGDiffConfig.enabled = false
Expected behavior
Filtering is working even with ximgdiff disabled.
Actual behavior
Filtering is not working with ximgdiff disabled.
I'll reopen this in the reg-viz/reg-cli-report-ui repo directly.