Release seems to be missing types/Actions.ts

Question

Release seems to be missing types/Actions.ts

teemuandersen opened this issue 5 years ago · comments

Version 5.0.3 introduced types for Actions (src/types/Actions.ts). These are however missing from the builds (5.0.3, 5.0.4). This breaks type checking:

node_modules/redux-zero/utils/bindActions.d.ts:2:24 - error TS2307: Cannot find module '../types/Actions'.

Matheus Lima · Answer 1 · Thu Jul 11 2019 22:08:13 GMT+0800 (China Standard Time)

@teemuandersen could you please run this locally and check if this solved your issue?

Teemu Andersén · Answer 2 · Mon Jul 22 2019 15:02:57 GMT+0800 (China Standard Time)

@matheusml Sorry that it took some time to respond. I was on holidays without laptop. But IMO that rollup line was part of it. But should the package.json files section contain types folder as well? I ran yarn pack and types folder was still missing.

Aliaksei Kislou · Answer 3 · Tue Sep 03 2019 16:22:01 GMT+0800 (China Standard Time)

Same for me here, types folder is missing from the package installed in node_modules. Just adding types in package.json's files should be fine to fix it.

Makinde Adeagbo · Answer 4 · Sat Oct 26 2019 13:02:45 GMT+0800 (China Standard Time)

Any update here? Just came across this.

Matheus Lima · Answer 5 · Thu Nov 07 2019 22:14:08 GMT+0800 (China Standard Time)

Version 5.1.1 will have the fix. Sorry about that.