The state of redux-autoform-material-ui
andrerpena opened this issue · comments
Please, update this thread with the state of this repo. Is it working already? Plans?
Actually the only I have are the groups and checkbox, I'm trying to fix the demo to test this components, and I want to keep it working with the rest.
Ok, thanks. No problem. Let's update this thread as we go further.
Okey, I will keep this open and when getting advance I will reference this issue. 😄
@andrerpena I'm currently working on setting up the demo in order to keep the component migration and test their behaviour. I have good news about styles. The latest versions of Material-UI have introduced the className props to all it's components, so you will be able to style them. What I want to do, it's to mark all the components with css class names, so the final users can override the css and easily style the components in the way they want.
@andrerpena @danigomez I'm fixing the demo, now some basic components are working:
- TextBox
- TextArea
- Password
- WizardGroup
- TabGroup
But some of them require a bit of work to emulate properly part of the functionality offered by bootstrap. So I will keep working on them.
The demo really looks awful, but it will be good with a lof of work I will be putting on.
@JonatanSalas this is really really good news! Congratulations!
Is the demo published already? Or do I have to download the repo?
@andrerpena You have to download the repo for now. Because I don't have all components implemented.
Ok.. I'll do it when get home. Great
This is how it actually looks
After final fixes
Please... Add paddings to the form. If you do it it will be amazing. =)))
Em 30 de ago de 2016 5:41 PM, "Jonatan E. Salas" notifications@github.com
escreveu:
After final fixes
[image: captura de pantalla de 2016-08-30 17 40 50]
https://cloud.githubusercontent.com/assets/7697196/18106191/fb506362-6ed8-11e6-8ebc-47c078f582ea.png—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABghdUEDWrwc8aAq9N2ARY7_dZN4JOuJks5qlJV9gaJpZM4JurW3
.
@JonatanSalas Congrats by the way. Awesome job. (just please add paddings)
it's a work in progress maaaaaaan jajajaja
hauhau sorry. Good progress though.
jajaja no trouble! We are on the way
@andrerpena fixed!
@andrerpena @danigomez this is the status:
- TextBox
- TextArea
- Password
- WizardGroup
- TabGroup
- CheckBox
- Radio
Getting better.. Except that I'd add more padding to the top. But this is getting really beautiful
About the components, you're getting there. Congrats dude!
ok! We will add that padding
Great.. by the way, I prefer the option in which the top bar (update, inline.. stacked..) has gray buttons instead of blue buttons. I think it's prettier, but that's just my opinion :)
It has grey buttons now!
With Top padding and grey buttons!
Beautiful!
@andrerpena @danigomez this is the current status:
- TextBox
- Number
- TextArea
- Password
- WizardGroup
- WizardTabGroup
- TabGroup
- CheckBox
- Radio
I have refactored the demo because I was needing a more organized folder structure. I have to keep on adding more functionallity to this components in order to emulate the features of bootstrap-ui.
Guys, the demo is published now with the components I current have here: https://redux-autoform.github.io/redux-autoform-material-ui/
First. Amazing job. Congrats. Really good work. Some thoughts:
- The presets should be rebuilt to reflect Material. Maybe, for instance,
addonBeforeandaddonAftershould be removed from TextBox just because that's not how Material works. The presets should be refactored. - Once you consider it to be in a "presentable" state, we should update the RAF's readme.md file to link to this demo (if you didn't already). The same for the RAF-MUI one.
@andrerpena when you can, could you look at the presets and modify them 😄?
This is the current status:
- TextBox
- Number
- TextArea
- Password
- Group
- WizardGroup
- WizardTabGroup
- TabGroup
- CheckBox
- Radio
- Select
This days I will be working on the last components that are the following ones:
- FieldGroup
- LookUp
- DatePicker/TimePicker (This one should be separated, I suppose)
- FileUpload
- Static
And at last add tests with enzyme.
@andrerpena @danigomez We are able to release a beta version!
- TextBox
- Number
- TextArea
- Password
- Group
- WizardGroup
- WizardTabGroup
- TabGroup
- CheckBox
- Radio
- Select
- FieldGroup
- LookUp (This has a small bug that I will solve)
- DatePicker/TimePicker (This one support date and time, but not datetime, I have to work on this one)
- FileUpload
The only that rest:
- Static
The demo is currently up to date, so you can play with the components that we currently have! 😄 Let me know when you find something!
@andrerpena you can start to link the Demo in readme.md
I have added support for Questionnaire Forms. Then I will add Support for Wizard with Stepper. Added component:
- QuestionnaireGroup
@danigomez I will do some refactors in Wizard/WizardTabGroup/TabGroup. I don't like the way that we use to update the context of this Groups, we should handle this in the componentWillReceiveProps callback, as I'm doing now on QuestionnaireGroup and I think that we should use the Context API from React.
I don't know if is the same thing, that callback is not called at first
render and the context will be empty
El 10/9/2016 7:29 p. m., "Jonatan E. Salas" notifications@github.com
escribió:
@danigomez https://github.com/danigomez I will do some refactors in
Wizard/WizardTabGroup/TabGroup. I don't like the way that we use to
update the context of this Groups, we should handle this in the
componentWillReceiveProps callback, as I'm doing now on QuestionnaireGroup.—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#28 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ABX6jwdQok0qRkd8AOyX92OyNsQTKqdsks5qoy9HgaJpZM4JurW3
.
I'm using componentDidMount and componentWillReceiveProps, the first one to setup previously to the initial render, and the second one, to setup the rest of the time that some prop change.
The new state of this is that I have released a version 1.0.0 of the library to start testing with redux-autoform.
I have finally fixed the bug with Lookup component, and added the Static one. I have started to add some basic tests with enzyme, I will keep working on them.