Support for pushing metrics to prometheus

[Shivam Chaturvedi]

First of all thanks for constantly developing this library based on inputs from the community. I am glad to see that we have instrumented connection level metrics via rueidisotel. I was wondering if it would be possible to have a way to push these metrics to prometheus as well? Something like https://github.com/redis/go-redis/tree/master/extra/redisprometheus.

Would be happy to work on this, if needed, as well.

[Rueian]

Hi @DestroyerAlpha,

Does an otel prometheus exporter fit your needs?
https://github.com/open-telemetry/opentelemetry-go/blob/main/example/prometheus/main.go

[Shivam Chaturvedi]

We are on go1.18 so probably would have to upgrade the go version for that as well, since it requires go1.20. Do we see a future plan to integrate it inhouse?

[Rueian]

Do we see a future plan to integrate it inhouse?

Sorry, I didn’t get you. What did you mean by that? Or what kind of functionalities you need to integrate with your in-house infrastructure?

[Shivam Chaturvedi]

I meant do we plan to export prom metric internally from rueidis instead of using an exporter?

[Rueian]

@DestroyerAlpha,

Oh, I see. Yes, we can have a rueidisprom subpackage if we keep the core rueidis depending on fewer packages.

So, there are two things we can do:

1. Introduce the rueidisprom subpackage with its own go.mod separated from the root one.
2. Let rueidisotel have its own go.mod (#447).

Would you like to help the first one?

[Shivam Chaturvedi]

Sure I can help with the first one

[Shivam Chaturvedi]

Added a PR for the same @rueian

[Rueian]

Hi @DestroyerAlpha,

I would like to release the next v1.0.28 recently. Is there any chance of bringing the real implementation rueidisprom subpackage to life? Or I may need to revert it when releasing the next version.

[Shivam Chaturvedi]

@rueian Hey would raise a PR for this ASAP.