redis / redis-io

Application running http://redis.io

Home Page:http://redis.io

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

STRALGO LCS sytanx spec not accurate

patpatbear opened this issue · comments

currently STRALGO LCS syntax spec is:

STRALGO LCS [KEYS ...] [STRINGS ...] [LEN] [IDX] [MINMATCHLEN <len>] [WITHMATCHLEN]

which IMHO is not accurate, and might be confusing:

  • KEYS ..., STRINGS ... seems like the LCS algo can accept arbitary number of KEY or STRING
  • [KEYS ...] [STRINGS ...] seems like LCS can accept either KEYS, STRINGS , or both or neither

I suggest the one used in the source code comment:

STRALGO LCS [IDX] [MINMATCHLEN <len>] [WITHMATCHLEN]  STRINGS <string> <string> | KEYS <keya> <keyb>