redis / jedis

Redis Java client

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Add support for configuring connection pool to MultiClusterPooledConnectionProvider

jarkus4 opened this issue · comments

Currently MultiClusterPooledConnectionProvider (redis.clients.jedis.providers.MultiClusterPooledConnectionProvider) creates new instance of ConnectionPool for each of configured clusters (MultiClusterClientConfig.GetClusterConfig()). This pool is created without providing any pool specific configuration (using constructor without JedisPoolConfig param), making it impossible to specify a number of pool specific settings eg maximum number of connections.

Please add possibility of passing JedisPoolConfig to be used during construction of those pools, preferably on the per cluster basis (ClusterConfig seems like a fitting place to pass it, but Im not sure)

hi, I am a new contributor. Can you give same more info about the request?

What kind of info do you need?

I would like to be able to set optional JedisPoolConfig member in ClusterConfig object (just as I set HostAndPort and JedisClientConfig). Then if its set it should be passed on when creating ConnectionPool for this cluster (as an additional constructor parameter compared to current one).

If you are asking about how to use MultiClusterPooledConnectionProvider in general its basic documentation is here: https://github.com/redis/jedis/blob/master/docs/failover.md

Hi, I am also a new contributor 🤩
@sazzad16 @jarkus4 @traitsisgiorgos please help review my pr 🙇

Resolved by #3801