redhat-qe-security / SCAutolib

Library for automation of smart card testing

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Install missing packages

x00Pavel opened this issue · comments

Two things here:

  • --install-missing flag is working in the opposite way: if set, then the value is False (missing packages are not installed), and the opposite if not set (value is True)
    • Possible solution: change default value on line to False
  • If the library is supposed to install missing packages, but all packages are installed, then the function for installing packages would be called with an empty list. That would result failer in for DNF command on this line
    • Possible solution: add check for empty list