red-coracle / episodes

Keep track of which television show episodes you've seen!

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Fix menu colour bug when viewing Series info

robinpaulson opened this issue · comments

When I am viewing a particular series and click on the "menu" button, the text is nearly the same colour as the menu background (white on very pale grey). In all other situations (overview, season), the text and background contrast: black on very pale grey.

Are you able to get a screenshot? The menu looks correct to me on all the phones/emulators I've tested.

Yes. Before you ask why I didn't screenshot: I can't, I use Replicant, which doesn't have the binary drivers required for screenshots.

I also included a shot of the "series" screen, on which the text is easily readable.

20191113_174506
20191113_174525

Every device/emulator I've tried always looks like this instead of popping up at the bottom and I don't know Android well enough to say why yours is different:
image

That being said, I'm thinking it has to do with the theme setting here. One option would be to remove it all and have it be light-on-dark like this:
image

I'm intrigued why it only happens in one menu, but not the others. I think white on black would be a good default though, it's easier on the eyes.

I used to have this exact problem on my Galaxy SII (on 4.1.2 JB) too. I don't have it on my current Zenfone. Unfortunately I cannot test any changes as the Galaxy went bust recently, but it may have had something with it being an AMOLED phone therefore using a system-wide dark theme. The Zenfone isn't, so it doesn't use a dark theme. I also had the popping-up at the bottom thing, I can only suspect it may have had something to do with the Galaxy having physical buttons (the Zenfone doesn't do this either). To be fair though, I'm now using this fork whereas previously I was using the old app.

Fixed with the new release! Closing