cglm incorrectly assumes that SSE2 is also available when SSE1 is

Question

cglm incorrectly assumes that SSE2 is also available when SSE1 is

aryalaadi opened this issue 5 months ago · comments

aryal commented 5 months ago

this causes builds for i686 to fail

related issue

Recep Aslantas · Answer 1 · Wed Mar 27 2024 20:45:46 GMT+0800 (China Standard Time)

Hi @aryalaadi,

You are right we must check these separately. Actually most of existing operations are f32 which is supported by SSE. There are some exceptions like _mm_castsi128_ps and maybe more... We can check where SSE2 is not supported and fallback some intrinsics to SSE if possible.

Added to TODOs, but a PR would indeed bring the fix more quickly

Recep Aslantas · Answer 2 · Mon Apr 01 2024 04:40:26 GMT+0800 (China Standard Time)

@aryalaadi I tried to fix the issue at #412 any help, feedbacks would be awesome to make the work bug-less

Recep Aslantas · Answer 3 · Mon Apr 01 2024 23:11:46 GMT+0800 (China Standard Time)

The issue is fixed at v0.9.4: https://github.com/recp/cglm/releases

Thanks for reporting this.