recp / cglm

📽 Highly Optimized 2D / 3D Graphics Math (glm) for C

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Should there be a dot product for integer vectors?

vitassuper opened this issue · comments

I found that the dot product function is implemented only in the vec2.h header. Should there be a corresponding function glm_ivec2_dot in the ivec2.h header?

Hi @vitassuper,

Yes that can be, all vector families can have dot product function. A PR that implement this would be appreciated, otherwise I'll add TODOs and implement it in an available time.

Hi @vitassuper,

Yes that can be, all vector families can have dot product function. A PR that implement this would be appreciated, otherwise I'll add TODOs and implement it in an available time.

I will create a PR

I created a pull request that adds a dot function, along with several other functions, for ivec2 and ivec3. #381

@vitassuper thanks the PR is merged 👍