recp / cglm

📽 Highly Optimized 2D / 3D Graphics Math (glm) for C

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

`glms_rotate_atm` has wrong signature

v1993 opened this issue · comments

glms_rotate_atm(mat4s m, vec3s pivot, float angle, vec3s axis) {

It makes no sense to accept matrix as the first argument, since this function initializes it.

Hi @v1993,

You are correct m is dest in array api, we dont need it in struct since we can alloc and return it.

We can drop it

@v1993 5be1c2f addresses the issue.

Thanks 😊