recp / cglm

📽 Highly Optimized 2D / 3D Graphics Math (glm) for C

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Struct API missing 3D Affine Transform

FrostKiwi opened this issue · comments

I found both...

glm_mul_rot(mat4 m1, mat4 m2, mat4 dest) {

glm_inv_tr(mat4 mat) {

...to be very useful optimizations and use them in my camera calculation code. I recently switched to the struct API and found them to be missing, requiring me to use

glm_mul_rot(gctx.cam.view_matrix.raw, gctx.cam.cam_rotation_matrix.raw,
	gctx.cam.view_matrix.raw);
glm_inv_tr(gctx.cam.view_matrix.raw);

Would be really nice if they could be added to the struct api.

Wow yes indeed we should add them to struct api (affine-mat.h), a PR would be nice to bring these to struct api otherwise I'll do asap :)

Wow yes indeed we should add them to struct api (affine-mat.h), a PR would be nice to bring these to struct api otherwise I'll do asap :)

Kinda hacked it into my codebase already. I'll make a PR later this evening.

@FrostKiwi thanks 🤗

@FrostKiwi thanks 🤗

@recp added in PR #317

Since the PR is merged, I'm going to close this issue, feel free to bring any issues, ideas, feedbacks, contributions ..

Thanks