Struct API missing 3D Affine Transform
FrostKiwi opened this issue · comments
I found both...
cglm/include/cglm/affine-mat.h
Line 115 in adec2ee
cglm/include/cglm/affine-mat.h
Line 166 in adec2ee
...to be very useful optimizations and use them in my camera calculation code. I recently switched to the struct API and found them to be missing, requiring me to use
glm_mul_rot(gctx.cam.view_matrix.raw, gctx.cam.cam_rotation_matrix.raw,
gctx.cam.view_matrix.raw);
glm_inv_tr(gctx.cam.view_matrix.raw);
Would be really nice if they could be added to the struct api.
Wow yes indeed we should add them to struct api (affine-mat.h), a PR would be nice to bring these to struct api otherwise I'll do asap :)
Wow yes indeed we should add them to struct api (affine-mat.h), a PR would be nice to bring these to struct api otherwise I'll do asap :)
Kinda hacked it into my codebase already. I'll make a PR later this evening.
@FrostKiwi thanks 🤗
@FrostKiwi thanks 🤗
Since the PR is merged, I'm going to close this issue, feel free to bring any issues, ideas, feedbacks, contributions ..
Thanks