[FEATURE] Support Python 3.12
daviddavo opened this issue · comments
I know you just updated it to support Python 3.11, but Manjaro or Ubuntu now use Python3.12 by default.
let's try, this can be as simple as changing a few lines of code, or we might need to fix many dependencies.
- PR gate: https://github.com/recommenders-team/recommenders/actions/runs/9090197009
- CPU: https://github.com/recommenders-team/recommenders/actions/runs/9090207202
- GPU: https://github.com/recommenders-team/recommenders/actions/runs/9090207980
- Spark: https://github.com/recommenders-team/recommenders/actions/runs/9090209242
Issue with Cornac:
2024-05-15T05:14:26: Collecting cornac<2,>=1.15.2 (from recommenders[dev,gpu]@ git+https://github.com/recommenders-team/recommenders.git@809a1d39c3e4bdab72aa56ee80d9eb79413ac29d->-r /azureml-environment-setup/condaenv.8fr4a5nk.requirements.txt (line 3))
2024-05-15T05:14:26: Downloading cornac-1.18.0.tar.gz (5.8 MB)
2024-05-15T05:14:26: ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ 5.8/5.8 MB 76.2 MB/s eta 0:00:00
2024-05-15T05:14:26: Preparing metadata (setup.py): started
2024-05-15T05:14:26: Preparing metadata (setup.py): finished with status 'error'
2024-05-15T05:14:26: failed
2024-05-15T05:14:26: Pip subprocess error:
2024-05-15T05:14:26: Running command git clone --filter=blob:none --quiet https://github.com/recommenders-team/recommenders.git /tmp/pip-install-va67dnkb/recommenders_830bb823f0204ab9ae042e7d5057b430
2024-05-15T05:14:26: Running command git rev-parse -q --verify 'sha^809a1d39c3e4bdab72aa56ee80d9eb79413ac29d'
2024-05-15T05:14:26: Running command git fetch -q https://github.com/recommenders-team/recommenders.git 809a1d39c3e4bdab72aa56ee80d9eb79413ac29d
2024-05-15T05:14:26: Running command git checkout -q 809a1d39c3e4bdab72aa56ee80d9eb79413ac29d
2024-05-15T05:14:26: error: subprocess-exited-with-error
2024-05-15T05:14:26:
2024-05-15T05:14:26: √ó python setup.py egg_info did not run successfully.
2024-05-15T05:14:26: │ exit code: 1
2024-05-15T05:14:26: ╰─> [2 lines of output]
2024-05-15T05:14:26: We need some dependencies to build Cornac.
2024-05-15T05:14:26: Run: pip3 install Cython numpy scipy
2024-05-15T05:14:26: [end of output]
2024-05-15T05:14:26:
2024-05-15T05:14:26: note: This error originates from a subprocess, and is likely not a problem with pip.
2024-05-15T05:14:26: error: metadata-generation-failed
2024-05-15T05:14:26: √ó Encountered error while generating package metadata.
2024-05-15T05:14:26: ╰─> See above for output.
2024-05-15T05:14:26: note: This is an issue with the package mentioned above, not pip.
2024-05-15T05:14:26: hint: See above for details.
2024-05-15T05:14:26: CondaEnvException: Pip failed