recommenders-team / recommenders

Best Practices on Recommendation Systems

https://recommenders-team.github.io/recommenders/intro.html

[FEATURE] Upgrade fastai to v2

SimonYansenZhao opened this issue 10 months ago · comments

Simon Zhao commented 10 months ago

Description

fastai has breaking changes in v2, which makes the code in recommenders incompatible with fastai v2. For example, CollabDataBunch is removed in fastai v2.

Expected behavior with the suggested feature

It should be compatible with fastai v2 because fastai v1 is not maintained.

Other Comments

There are 3 repos related to fastai:

fastai1: fastai v1
fastai2: fastai v2 (archived)
fastai: fastai v2+

See also

Miguel Fierro commented 3 months ago

@SimonYansenZhao do you think this issue is fixed?

Simon Zhao commented 3 months ago

@SimonYansenZhao do you think this issue is fixed?

Yes