Make RC_MAX_LAYERS and RC_MAX_NEIS configurable at build time
bmorel opened this issue · comments
Those are currently global constants, which require modifying recast's source itself (see this issue from a game that uses recast).
Would it be ok to make it possible to make this a cmake option instead? This way, it would be possible for users to at least change the value at compilation time without having to modify recast's code directly.
If yes, I'll write a PR for this.
Maybe it would be possible to make the value dynamic at runtime too, but I'm not sure how much this would require patching or if it would be a bad idea for performance or other techical reasons.
Hi! I'm not terribly familiar with cmake's build configuration system, but I assume it's essentially setting C preprocessor variables like other build systems do.
I'd be open to moving these integers to #define
's instead since it'd expose configuration to build systems like cmake, assuming that's what cmake options are operating with.