Giters

reactphp / dns

Async DNS resolver for ReactPHP.

Home Page:https://reactphp.org/dns/

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Test failure because f integer overflow on 32-bit system

remicollet opened this issue · comments

commented 
There were 20 errors:
1) React\Tests\Dns\Query\TcpTransportExecutorTest::testTriggerIdleTimerAfterQueryRejectedOnCancellationWillCloseSocket
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:188
2) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryAgainAfterPreviousWasCancelledReusesExistingSocket
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:239
3) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsWhenServerIsNotListening
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:254
4) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryStaysPendingWhenClientCanNotSendExcessiveMessageInOneChunk
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:289
5) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryStaysPendingWhenClientCanNotSendExcessiveMessageInOneChunkWhenServerClosesSocket
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:332
6) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsWhenClientKeepsSendingWhenServerClosesSocket
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:366
7) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsWhenServerClosesConnection
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:416
8) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryKeepsPendingIfServerSendsIncompleteMessageLength
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:455
9) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryKeepsPendingIfServerSendsIncompleteMessageBody
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:489
10) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsWhenServerSendsInvalidMessage
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:520
11) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsWhenServerSendsInvalidId
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:571
12) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsIfServerSendsTruncatedResponse
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:622
13) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryResolvesIfServerSendsValidResponse
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:662
14) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryRejectsIfSocketIsClosedAfterPreviousQueryThatWasStillPending
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:685
15) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryResolvesIfServerSendsBackResponseMessageAndWillStartIdleTimer
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:719
16) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryResolvesIfServerSendsBackResponseMessageAfterCancellingQueryAndWillStartIdleTimer
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:753
17) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryResolvesIfServerSendsBackResponseMessageAfterCancellingOtherQueryAndWillStartIdleTimer
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:787
18) React\Tests\Dns\Query\TcpTransportExecutorTest::testTriggerIdleTimerAfterPreviousQueryResolvedWillCloseIdleSocketConnection
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:828
19) React\Tests\Dns\Query\TcpTransportExecutorTest::testClosingConnectionAfterPreviousQueryResolvedWillCancelIdleTimer
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:866
20) React\Tests\Dns\Query\TcpTransportExecutorTest::testQueryAgainAfterPreviousQueryResolvedWillReuseSocketAndCancelIdleTimer
TypeError: stream_set_chunk_size(): Argument #2 ($size) must be of type int, float given
/builddir/build/BUILDROOT/php-react-dns-1.5.0-1.fc35.noarch/usr/share/php/React/Dns/Query/TcpTransportExecutor.php:188
/builddir/build/BUILD/dns-b22b0b20278e8535e633ab71a52472c5bf620aa1/tests/Query/TcpTransportExecutorTest.php:904

32-bit arm is still quite common

commented

@remicollet Thanks for reporting, I can indeed reproduce this on (increasingly less common) 32 bit platforms 👍

This is caused by my recent change in https://github.com/reactphp/dns/pull/172/files#diff-cde9e8c539defb086472120d9570d3cb4ca4f02924bd010e8bfce932079a5ddaR188, so this can temporarily be worked around by downgrading to v1.4.0. I'll file a PR to address this for the next version in a moment or two 👍