Giters

reactjs / react-art

React Bridge to the ART Drawing Library

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

modern browser colors cause an error

boygirl opened this issue · comments

commented

Hi there!

I'm converting a react library from svg to react-art, and I got hung up on using colors like "tomato", which cause an error, and result in nothing being rendered. I tracked the problem down to the art library, and opened a PR there. sebmarkbage/art#12. I'd love a version bump whenever that lands.

Thanks!

commented

P.S. you can test out this change in art on my branch https://github.com/formidablelabs/react-art/tree/supportBrowserColors

commented

See my comment in sebmarkbage/art#12

We'd have to make a solid case for why everyone else using this library with custom colors should have to download this list of hardcoded colors. Generally I think it makes more sense to define your own list of hardcoded colors.

E.g. myColorSet.highlightedRed or myColorSet.buttonColor. You can have your own list just represent the built-in browser colors if you want.