Setting up CI and test site
koba04 opened this issue · comments
Currently, CircleCI doesn't run for PRs from fork repositories, so I enabled the setting.
If it doesn't cause any problems, I'd like to require status checks to pass before merging.
In addition to that, Is it helpful to enable deploy preview using Neflify like reactjs/reactjs.org?
CI for PRs is working very well, so I think requiring the green status is fine.
I know nothing about the official deploying process, but setting up an independent test site on Netlify does not "pollute" the codebase and has no side effects, right?
I've enabled the setting so now passing CircleCI check is required to merge PRs.
I know nothing about the official deploying process, but setting up an independent test site on Netlify does not "pollute" the codebase and has no side effects, right?
Yes, I assume that it only has to create settings on Netlify, which doesn't affect the codebase.
I'll work on that.
@gaearon I’d like to add deploy previews for each PRs using Netlify. reacts/reactjs.org provides the feature using reacts-bot.
Can we use the bot as well?
Should we configure the setting ourselves?
@tesseralis
Netlify integration has been enabled so I close this.