Japanese Translation Final Tasks!
tesseralis opened this issue · comments
お疲れ様でした！
You all are almost done translating the React docs into Japanese! There are couple more errands to do before we can mark the project as "completed"
- Replace "reactjs.org" to "ja.reactjs.org" in the following places:
- package.json
- site-constants.js
- gatsby-config.js
- MarkdownPage (the link href in "Edit this page")
- Change
html.jsto have the attributelang="ja" - Go over each section in the site to:
- Make sure there are no formatting errors (dangling markdown/html tags) or untranslated English
- Make sure the sections and style are consistent.
- Change the DocSearch API key. One of the maintainers needs to sign up for DocSearch
We're almost there everyone!
- Change
html.jsto have the attributelang="ja"
This is already done!
I will check it 😎
https://github.com/reactjs/ja.reactjs.org/pull/8/files#diff-58826c9c508b82875d8f9a9872d19e2dR10
@potato4d cool! The only one that's left is the MarkdownPage.
@potato4d ありがとうございます！！
Stuff I found:
- A lot of the comments in source blocks are still in English. for example, here
- The nav bar is still in English
- The section headers in the sidebar (Installation, Main Concepts, etc.) are in English
@tesseralis Many of them are intentional because most Japanese developers should understand simple words and phrases like "main concepts", "blogs" and "correct". Unlike some languages discussed in Slack, Japanese developers usually use English identifiers whenever possible. IMHO keeping some English words in navs and such is good for aesthetic purposes, too. Our current rule is not to touch code examples unless it absolutely contains long descriptive sentences.
@smikitky gotcha! we'll leave it as is then.
👋 all,
Regarding the last TODO, here is the key to use:
apiKey: '0a814a89e0c31ab1d55d440f967517b4',
indexName: 'reactjs_ja',
Thank you @potato4d for applying for it :)
@s-pace
Thanks!
いいと思います