Path to Demo
wps13 opened this issue · comments
Hello, James. When I was building the site, I added a link to a demo, which would be the storybook. How could we add this to the current version?
We would have to adjust the build script to do both I would think.
Sent with GitHawk
@wps13 I am looking into this, I have a few minutes this morning so I will see if I can get this fixed.
@wps13 Looks like it throwing a Type error and a ESLint error. But I have it building Storybook now inside the build process.
=> Failed to build the preview
ERR!
/tmp/ddb3da7/src/stories/Menu.stories.tsx
ERR! TypeScript error in /tmp/ddb3da7/src/stories/Menu.stories.tsx(18,6):
ERR! Type '{ path: string; desc: string; }' is missing the following properties from type 'OwnProps': link, title TS2739
ERR!
ERR! 16 | .add('Menu', () => <Menu />)
ERR! 17 | .add('Social Media Icon', () => (
ERR! > 18 | <SocialMedia path={LogoGithub} desc="Github Logo" />
ERR! | ^
ERR! 19 | ));
ERR! 20 |
ERR!
./src/components/Menu/index.tsx
ERR! Module Warning (from ./node_modules/eslint-loader/index.js):
ERR!
ERR!
Line 16:9: Using target="_blank" without rel="noopener noreferrer" is a security risk: see https://mathiasbynens.github.io/rel-noopener react/jsx-no-target-blank
ERR!
ERR!
ERR! @ ./src/stories/Menu.stories.tsx 2:110-147 2:422-426
ERR! @ ./src/stories sync \.stories\.tsx$
ERR! @ ./.storybook/config.js
ERR! @ multi ./node_modules/@storybook/core/dist/server/common/polyfills.js ./node_modules/@storybook/core/dist/server/preview/globals.js ./.storybook/config.js
ERR!
asset size limit: The following asset(s) exceed the recommended size limit (244 KiB).
ERR! This can impact web performance.
ERR! Assets:
ERR! vendors~main.c8a1e605a181a9cd3f49.bundle.js (676 KiB)
ERR! entrypoint size limit: The following entrypoint(s) combined asset size exceeds the recommended limit (244 KiB). This can impact web performance.
ERR!
Entrypoints:
ERR! main (693 KiB)
ERR! runtime~main.c8a1e605a181a9cd3f49.bundle.js
ERR! vendors~main.c8a1e605a181a9cd3f49.bundle.js
ERR!
main.css
ERR! main.c8a1e605a181a9cd3f49.bundle.js
ERR!
ERR!
webpack performance recommendations:
ERR! You can limit the size of your bundles by using import() or require.ensure to lazy load some parts of your application.
ERR! For more info visit https://webpack.js.org/guides/code-splitting/
@jameswlane I will take a look at this, probably forgot to update storybook after update the component.
@jameswlane The storybook would be the one with the loaders, not the one from the site.
@wps13 I have the Storybook demo working. Now we just need to pull the files from the other repo and maybe adjust some of the configs.
@jameswlane thanks!