Upgrading to Functional Component

Question

Upgrading to Functional Component

shegz101 opened this issue a year ago · comments

Is your feature request related to a problem? Please describe.
Trying to integrate into a project using Functional Components

Describe the solution you'd like
I was hoping there could be an upgrade for this to be compatible with projects that are using Functional Component. From the sample on how to import this tool, I noticed that it was done using Class Components, so I was thinking if we could upgrade it to FC.

Describe alternatives you've considered
Honestly, none.

Additional context
Add any other context or screenshots about the feature request here.

James W. Lane III · Answer 1 · Wed Feb 15 2023 23:33:05 GMT+0800 (China Standard Time)

@shegz101 I can add this to the list of improvements.

Pull requests are always welcome. If you would like to put this together and do a PR, I would be more than happy to merge it.

Shegzi · Answer 2 · Thu Feb 16 2023 01:36:50 GMT+0800 (China Standard Time)

Alright @jameswlane I will doing that and creating a PR for it.

James W. Lane III · Answer 3 · Thu Feb 16 2023 02:57:54 GMT+0800 (China Standard Time)

@shegz101 Awesome, thank you.

I will move to fix the pipeline and move it from CircleCI to GitHub Actions to the top of my list for the repo.

James W. Lane III · Answer 4 · Fri Feb 17 2023 09:29:58 GMT+0800 (China Standard Time)

@shegz101 I started fixing the build process in this PR

Just need to fix half the test and it should be good to merge to master. It would give you a working app to start with.

Shegzi · Answer 5 · Fri Feb 17 2023 16:05:07 GMT+0800 (China Standard Time)

Alright, just keep me posted.

James W. Lane III · Answer 6 · Mon Feb 20 2023 03:17:26 GMT+0800 (China Standard Time)

@shegz101 Once I get this fixed, I will have everything worked out. Emotion stopped working the way it used to. I have an issue open with them here

James W. Lane III · Answer 7 · Fri Feb 24 2023 11:20:49 GMT+0800 (China Standard Time)

@shegz101, a friend (@murillomamud) of mine, came up with an alternative solution and will knock out a pr this weekend to fix the broken test till we figure out why emotion matchers are not working. The code repo should be ready to start working on by the end of the week.

Shegzi · Answer 8 · Fri Feb 24 2023 19:55:55 GMT+0800 (China Standard Time)

Okay, when everything is up and running I can come in and do the upgrade then you can merge it. Thanks.

James W. Lane III · Answer 9 · Thu Mar 09 2023 22:07:08 GMT+0800 (China Standard Time)

@shegz101 You should be good to go for adding functional components. 👍 Thank you for working on this.

Shegzi · Answer 10 · Fri Mar 10 2023 15:18:16 GMT+0800 (China Standard Time)

Alright, I will look into it right away. Thanks.

Shegzi · Answer 11 · Thu Mar 30 2023 01:17:39 GMT+0800 (China Standard Time)

@shegz101 You should be good to go for adding functional components. 👍 Thank you for working on this.

Hello James, I will look into this today. My system crashed that's the issue have been facing for a while now. Would get it working hopefully today. Thanks for understanding.

James W. Lane III · Answer 12 · Thu Mar 30 2023 23:56:44 GMT+0800 (China Standard Time)

That sound's good. It's not a huge rush; real life happens sometimes.

Shegzi · Answer 13 · Fri Mar 31 2023 00:53:05 GMT+0800 (China Standard Time)

That sound's good. It's not a huge rush; real life happens sometimes.

Alright.

Shegzi · Answer 14 · Fri Apr 07 2023 22:03:04 GMT+0800 (China Standard Time)

That sound's good. It's not a huge rush; real life happens sometimes.

Hello James, I just forked and cloned the repo. Looking forward to what's next. I would learn a lot via this contribution. It is my first open-source contribution and am so happy to be doing this, I would do everything it takes to learn a lot and get the issue fixed. Please, I will need your help a lot as I am new to lots of libraries used. Thanks.