react-native-menu / menu

UIMenu Component for React Native

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

iOS menu is displayInlined with 0.74 and new architecture when not set

alanleedev opened this issue · comments

NOTE: This issue requires fix in React Native codegen but filing here for folks who may run into the issue in the meanwhile.
This issue is expected to be fixed in react-native PR: facebook/react-native#44294

Problem:
So Props.h file generated from native component codegen does not properly initialize C++ struct.
So in effect, if you run the example code on iOS, displayInline which is an optional prop in MenuView unintentionally can be set to true as it is not initialized properly in C++ and sub menus can appear at top level.
Also using WithDefault in the TypeScript spec file does not fix this.

This issue is fixed with 74.0.1 (PR for fix)