🚧🚧 Looking for collaborators and financial backers 🚧🚧
vonovak opened this issue · comments
Hello, I'm putting this up to explain what you can expect from me as a maintainer and to inform about some future updates that should be done:
The module is a wrapper around the google sign in SDK, and is, I believe, in a fairly stable state. It supports expo as well.
There are 2 major features missing:
-
one tap for android which is part of the google identity SDKs.
-
support for the new architecture.
Also see my tweet.
I'm looking for companies who would help to fund these new features or people willing to help with implementation and maintenance of the module. Reason I'm reaching out like this is that I do not want to spend much of my free time doing open source work (features, bugfixes, issue handling, docs...) that is used in for-profit projects. Please note I'm not using this module in any project I'm currently working on.
You can sponsor this here or here. Feel free to get in touch over twitter DM or email me.
If you need me to add some missing features or get help of any kind, you can get in touch with me via https://react-native-training.eu - as a paid service.
If you want to get involved in the maintenance of this module, let me know and I'll invite you to the repo! Ideally, I'd like you to have some track record in OSS before I do that - you can easily contribute from a fork too, in order to build that track record. 🙂
Thank you!
Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue?
screenshot
My react native version is
@chromneil-pedeglorio thanks for asking, please read the error message and act accordingly, this is a problem with your setup. Thanks
Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue?
screenshot
My react native version is
is your problem got fixed.
Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue?
screenshot
My react native version is
is your problem got fixed.
Hi, there @ashishonmobile apparently my problem is fixed based on what @vonovak said my setup cause the problem.. so I just focused on reproducing the bug and like a miracle, it worked correctly.
I though do not have any issue setting this module up with my project, still I must say, am not happy the the project will be lacking maintainence as stated by the proj. owner
@Gems-gr I have updated the original comment to make one thing clear:
If you want to get involved in the maintenance of this module, let me know and I'll invite you to the repo!
so - if you're not happy with the lack of maintenance from me, and want to get involved in the maintenance, please let me know! It's not like the project is just sitting here out of reach, it's open source and anyone can contribute! 🙂
Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue?
screenshot
My react native version is
is your problem got fixed.
Hi, there @ashishonmobile apparently my problem is fixed based on what @vonovak said my setup cause the problem.. so I just focused on reproducing the bug and like a miracle, it worked correctly.
How did you fix the issue please ?
I'd like to help you a little bit.
Can I join the repo?
Hi there! can I ask something I`m currently using this module. but then I encounter an error in configuration it says RN GoogleSignin native module is not correctly linked. does this maintenance cause the issue?
screenshot
My react native version is
is your problem got fixed.
Hi, there @ashishonmobile apparently my problem is fixed based on what @vonovak said my setup cause the problem.. so I just focused on reproducing the bug and like a miracle, it worked correctly.
How did you fix the issue please ?
Hi @inas20,
Check your manual setup eventhough. I`m using react-native version: 0.61.5 and using a package from this version must be auto-link i think this is not applicable on all packaged, and so i fixed my issue just checking may manual setup carefully and manipulating the versions of the google-signin. Try to use this version
"dependencies": {
"@react-native-community/google-signin": "^5.0.0"
}
Hi @vonovak, I want to support this module by writing the Expo Config plugin for it. So, what do you think?
Hi, sounds great! Please feel free to open a pull request for it 🙌. Thank you! 😊
I no longer use this module in production and I do not have time to give it regular maintenance.
I'm curious: what do you use in production now? Or do you not use React Native or Google Sign-in any more?
I'm curious: what do you use in production now? Or do you not use React Native or Google Sign-in any more?
I'm just not working on a project that uses google sign in
For the record: Expo released SDK 46 a few days ago, which removes (it was deprecated in SDK 45) the expo-google-sign-in library, in favor of this library.
Thus, we'll see an increment of bug reports, issues, PRs, etc.
Thanks for the update @BrodaNoel.
For anyone new to this like me, here is the Expo documentation on this. It states that the Google Provider from Expo's AuthSession package is the new way but that this one (react-native-google-signin) can also be used. I'm diving in right now and I'll update this if I find anything new. First day in Expo/React Native, here goes nothing.
Thanks for the update @BrodaNoel.
For anyone new to this like me, here is the Expo documentation on this. It states that the Google Provider from Expo's AuthSession package is the new way but that this one (react-native-google-signin) can also be used. I'm diving in right now and I'll update this if I find anything new. First day in Expo/React Native, here goes nothing.
Any luck?
People: I have this package installed in Expo SDK 46 and it's working perfectly. Android and iOS. So... go for it!
@BrodaNoel RN GoogleSignin native module is not correctly linked. am facing this issue ... can you share the linking step that you went through?
@vonovak I have received an email from google saying "We detected requests to our OAuth 2.0 authorization endpoint from one or more of your OAuth client IDs within an embedded webview context".
as I used old version 5.0.0 I decided to upgrade to the newest one hoping that after 7.0.0 this library stopped using webview but I dont see any changes in behavior. does it still use webiew to open login page?
I am facing [Error: DEVELOPER_ERROR] Error Code 10 ? what is mean ?
will definitely contribute
Guys please be respectful of the creator!
After going through this thread, all I could see was selfishness of people.
They are getting paid at their job and here they are expecting the maintainers to do it for free.
Have some respect for the OSS maintainers.
The author had to hide so many comments, which shows people's negligence.
Thanks @vonovak for your contribution.
I understand how frustrating it can be to be maintainer without getting any support.
I am not using the library right now, still I'll sponsor to support you and keep you motivated.
This might help https://www.youtube.com/watch?v=VH1YBcVmM-M
Hello everyone,
quick update: the New Architecture as well as the new One-Tap sign in is available in the paid version of the package, see instructions here: https://github.com/react-native-google-signin/google-signin#project-setup-and-initialization
Thank you! 🙂