react-native-datetimepicker / datetimepicker

React Native date & time picker component for iOS, Android and Windows

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

7.6.4 ios Build fail

vbylen opened this issue · comments

Bug report

Compiling @react-native-community/datetimepicker Pods/RNDateTimePicker » RNDateTimePickerComponentView.mm

❌  (/Users/********/Documents/GitHub/********/node_modules/@react-native-community/datetimepicker/ios/fabric/cpp/react/renderer/components/RNDateTimePicker/ComponentDescriptors.h:21:62)

  19 |     using ConcreteComponentDescriptor::ConcreteComponentDescriptor;
  20 | 
> 21 |     void adopt(ShadowNode::Unshared const &shadowNode) const override {
     |                                                              ^ non-virtual member function marked 'override' hides virtual member function
  22 |       react_native_assert(std::dynamic_pointer_cast<RNDateTimePickerShadowNode>(shadowNode));
  23 |       auto pickerShadowNode = std::static_pointer_cast<RNDateTimePickerShadowNode>(shadowNode);
  24 | 


❌  (/Users/**********/Documents/GitHub/********/node_modules/@react-native-community/datetimepicker/ios/fabric/cpp/react/renderer/components/RNDateTimePicker/ComponentDescriptors.h:37:42)

  35 |       }
  36 | 
> 37 |       ConcreteComponentDescriptor::adopt(shadowNode);
     |                                          ^ non-const lvalue reference to type 'ShadowNode' cannot bind to a value of unrelated type 'const ShadowNode::Unshared' 
  38 |     }
  39 | };
  40 | 

Summary

Build fails with expo on new arch enabled

Steps to reproduce

  1. npx expo run:ios

Environment info

System:
  OS: macOS 14.1.1
  CPU: (10) arm64 Apple M1 Max
  Memory: 735.97 MB / 32.00 GB
  Shell:
    version: "5.9"
    path: /bin/zsh
Binaries:
  Node:
    version: 21.7.1
    path: /opt/homebrew/bin/node
  Yarn:
    version: 4.0.2
    path: /opt/homebrew/bin/yarn
  npm:
    version: 10.5.0
    path: /opt/homebrew/bin/npm
  Watchman: Not Found
Managers:
  CocoaPods:
    version: 1.15.2
    path: /opt/homebrew/bin/pod
SDKs:
  iOS SDK:
    Platforms:
      - DriverKit 23.4
      - iOS 17.4
      - macOS 14.4
      - tvOS 17.4
      - visionOS 1.1
      - watchOS 10.4
  Android SDK: Not Found
IDEs:
  Android Studio: 2022.3 AI-223.8836.35.2231.10406996
  Xcode:
    version: 15.3/15E204a
    path: /usr/bin/xcodebuild
Languages:
  Java:
    version: 20.0.2
    path: /usr/bin/javac
  Ruby:
    version: 2.6.10
    path: /usr/bin/ruby
npmPackages:
  "@react-native-community/cli": Not Found
  react: Not Found
  react-native: Not Found
  react-native-macos: Not Found
npmGlobalPackages:
  "*react-native*": Not Found
Android:
  hermesEnabled: true
  newArchEnabled: false
iOS:
  hermesEnabled: true
  newArchEnabled: true

datetimepicker version: 7.6.4

iOS version: 17.4

Same issue..

Same issue here

Same issue here... this started when enabling the new architecture

You can currently create a patch which includes the changes from this commit. Now it works for me.

Hello this should be fixed in v8 https://github.com/react-native-datetimepicker/datetimepicker/releases/tag/v8.0.0

Please open a new issue if the problem persists

Thank you!