Giters

react-native-community / jsc-android-buildscripts

Script for building JavaScriptCore for Android (for React Native but not only)

Geek Repo:Geek Repo

Github PK Tool:Github PK Tool

Number.toLocaleString crashes

torkelrogstad opened this issue · comments

commented

Issue Description

Calling Number.toLocaleString throws an error, Failed to format a number.

Version, config, any additional info

I'm running the jsc-android-intl variant of the prebuilt packages. Config file in my React Native are according to the documentation in this repo, except for android/app/build.gradle, where I had to use the following config to use the intl variant of the provided builds:

configurations.all {
    resolutionStrategy {
        eachDependency { DependencyResolveDetails details ->
            if (details.requested.name == 'android-jsc') {
                details.useTarget group: details.requested.group, name: 'android-jsc-intl', version: 'r224109'
            }
        }
    }
}

I found the config information above here. Any help greatly appreciated.

Originally I posted about this in #29 but I felt it was more appropriate to have a separate issue.

commented

This is related to #36. This is problem with loading ICU locale data. I'm currently working on this issue for over a week. I will inform you when I finish

commented

closing as duplicate of #36 , will update the README with the missing intl instructions

commented

@Kmakinator any progress with this?