Android Intl doesn't work as expected

Question

Android Intl doesn't work as expected

deecewan opened this issue 5 years ago · comments

David Buchan-Swanson commented 5 years ago

Issue Description

To start, I've created a small repro here: https://github.com/deecewan/TimeZoneTest

I set up a brand new project (npx react-native-cli init TimeZoneTest), and then followed the steps for React Native 0.59, and added the support for Intl. This works, because the Intl object actually exists now (yay!).

The problem is, the behaviour is not the same as on iOS when trying to format dates.

Here is the output on Android:

And the same code on iOS:

The same code on Android, with remote debug enabled:

(Note: My android emulator is set up to be in Australia/Brisbane. The iOS Simulator is set to my laptop's TZ, in Canada. In remote debug, it uses Chrome in my laptop's TZ).

As you can see, when formatting on the iPhone and in Chrome via Remote Debugging, the output is in the TZ of the 'device'. When rendering on Android, with Intl enabled, it renders in UTC/GMT. This seems to be inconsistent with how it should be rendering.

Version, config, any additional info

See repro reop for full details

React Native 0.59.8
jsc-android: 241213.x.x
android/app/build.gradle dep: implementation "org.webkit:android-jsc-intl:r241213"

Kudo Chien · Answer 1 · Wed May 15 2019 20:33:41 GMT+0800 (China Standard Time)

Hey @deecewan, your repo at https://github.com/deecewan/TimeZoneTest is empty. There is no way for me to confirm the date methods you used.

However, once enabling Remote Debugging, the actually JS engine is Chrome.
The Intl is supported by V8 not JSC and the timezone is your Chrome's timezone.
AFAIK, the behavior you described is expected.

David Buchan-Swanson · Answer 2 · Thu May 16 2019 06:55:28 GMT+0800 (China Standard Time)

hey @Kudo - sorry, forgot to push 😞

I know that when you enabled remote debugging, the engine is Chrome. The problem is that on iOS, when using JSC, it renders in the correct timezone. And, on Android, when using Chrome, it renders in the correct timezone. On Android, tho, with JSC, it always renders in UTC by default. Note that the first screenshot is rendered in UTC, and the second 2 screenshots are both in Mountain Time.

As stated, I'm using the Intl variant, so I'd expect it to behave the same way as Chrome/iOS JSC.

Kudo Chien · Answer 3 · Thu May 16 2019 19:21:50 GMT+0800 (China Standard Time)

Thank you for the briefly explanation.
I've confirm it is an issue and root cause is that IntlDateTimeFormat use ICU's ucal_getDefaultTimeZone to query current timezone.
And it is not integrate to Android persist.sys.timezone
https://github.com/WebKit/webkit/blob/master/Source/JavaScriptCore/runtime/IntlDateTimeFormat.cpp#L126
Need to patch handy.

David Buchan-Swanson · Answer 4 · Fri May 17 2019 00:48:42 GMT+0800 (China Standard Time)

Hmm. Interesting.

From here it looks like we could just ucal_setDefaultTimeZone, right?

Or, something like this from FreeRDP might be helpful

Kudo Chien · Answer 5 · Mon May 20 2019 19:08:08 GMT+0800 (China Standard Time)

Yes, I am now focusing on JSC crash issue.
Will find a time to fix a problem after that.

Dima Lebedynskyi · Answer 6 · Wed Nov 20 2019 05:00:03 GMT+0800 (China Standard Time)

@Kudo any update on this issue or PR?

Sirui Li · Answer 7 · Tue May 05 2020 22:10:29 GMT+0800 (China Standard Time)

in my testing. default timezone in Intl is always UTC. this behaviour is different from the default Date timezone.

> time.toString()
< Tue May 12 2020 22:00:00 GMT+0800 (HKT)

> time.toLocaleString('en', { timeZoneName: 'long' })
< 5/12/2020, 2:00:00 PM GMT

In the above example, toString is in GMT+8, while toLocaleString is GMT.

great-timofey · Answer 8 · Mon Jul 27 2020 18:03:17 GMT+0800 (China Standard Time)

I can confirm that this issue still exists (I'm using FormattedTime component from react-intl) and in Android version I have the same problem related with UTC zones, while iOS works correctly.

Spent a couple of hours trying to install different sets of polyfills for react-intl I've found a working solution.
For someone looking for fix - instead of default installation please use
yarn add jsc-android@npm:@kudo-ci/jsc-android

Many thanks to @Kudo for this. I cannot understand why his MR with fix is still in review (since September of 2019)... Dear maintainers, could you please pay more attention to this?

Andrew Goodale · Answer 9 · Mon Jul 27 2020 21:04:22 GMT+0800 (China Standard Time)

@great-timofey It seems like there are no active maintainers in this project anymore. @Kudo is there a process where you or someone else can bring someone up to speed as a maintainer for this repo? I would be interested, but I haven't done development in JavaScriptCore so I'd need lots of documentation and ramp-up time.

Kudo Chien · Answer 10 · Tue Jul 28 2020 00:08:39 GMT+0800 (China Standard Time)

Well, as Kudo#3 mentioned, I am not able to maintain react-native-community/jsc-android-buildscripts. That's why I went for a forked version.

I guessed from the past days, RN default to use JSC and that's the reason to have maintainers strictly.
If RN by default stick to Hermes, jsc-android could be a real community driven project.

I would be interested, but I haven't done development in JavaScriptCore so I'd need lots of documentation and ramp-up time.

@newyankeecodeshop To be honestly, I am not familiar JavaScriptCore internal as well. What I did is only about to build JSC Android version 😅

Andrew Goodale · Answer 11 · Tue Jul 28 2020 02:04:57 GMT+0800 (China Standard Time)

Thanks @Kudo I just assumed you are a maintainer because you are one of the largest contributors here. 🥇